Prefer the in-repo kernel for make integration - #875
Open
MayCXC wants to merge 1 commit into
Open
Conversation
The integration suite booted whichever kernel sat under bin/, so a kernel configured and built in the repo with `make -C kernel` took effect only if the fetched default was deleted by hand: a configuration change could be built, pass a rebuild, and never be the kernel a test ran against. The guest kernel is a variable of every integration result, so the one built from the repo's own configuration is preferred wherever it exists, with the kata-fetched kernel remaining the fallback for a checkout that never built one. This is the preference `LINUX_INTEGRATION_KERNEL` already expresses; `make integration` now expresses the same one.
MayCXC
force-pushed
the
integration-usb-kernel
branch
from
August 27, 2026 20:47
6fc2246 to
26f5c7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The integration suite booted whichever kernel sat under
bin/, so a kernel configured and built in the repo withmake -C kerneltook effect only if the fetched default was deleted by hand: a configuration change could be built, pass a rebuild, and never be the kernel a test ran against.The guest kernel is a variable of every integration result, so the one built from the repo's own configuration is preferred wherever it exists, with the kata-fetched kernel remaining the fallback for a checkout that never built one. This is the preference
LINUX_INTEGRATION_KERNELalready expresses;make integrationnow expresses the same one.Motivation and Context
The failure mode is a silent wrong answer rather than an error: you change the kernel configuration, build it, run the suite, and read results produced by a different kernel. Nothing in the output says which one booted.
Taking the preference that already exists for the Linux integration target, rather than inventing one, keeps the two from disagreeing.
Testing
make integrationuses the fetched default exactly as before.make -C kernelhaving produced one, the suite boots it.Type of Change