commands: replace force-unwrap with optional chaining in ImagePrune#1850
Open
ArasanDev wants to merge 1 commit into
Open
commands: replace force-unwrap with optional chaining in ImagePrune#1850ArasanDev wants to merge 1 commit into
ArasanDev wants to merge 1 commit into
Conversation
ArasanDev
force-pushed
the
fix/image-prune-force-unwrap
branch
from
4136ff3 to
9e9417f
Compare
ArasanDev
force-pushed
the
fix/image-prune-force-unwrap
branch
from
9e9417f to
8eead96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
In
ImagePrune.hasTag(_:),ref.tagis checked forniland then immediately force-unwrapped on the same line:This is unnecessary — Swift's optional chaining handles both cases without a crash risk:
This complies with the
NeverForceUnwraprule enforced by swift-format.Testing
make testpasses (561 tests)