Adds build fixture and migrates build CLI tests.#1848
Merged
Conversation
Code Coverage
|
jglogan
commented
Jun 29, 2026
| /// Creates a new scratch directory under ``testDir`` and returns its path. | ||
| /// | ||
| /// The directory is removed automatically when the fixture scope exits. | ||
| func createTempDir() throws -> FilePath { |
Contributor
Author
There was a problem hiding this comment.
I think we can get rid of this in a final cleanup pass. Since the tests themselves run in test-specific temp directories, creating a temp directory underneath is just unneeded boilerplate.
katiewasnothere
approved these changes
Jun 29, 2026
katiewasnothere
left a comment
katiewasnothere
left a comment
Contributor
There was a problem hiding this comment.
There's a couple places where we could be using helper functions (such as builderDelete) and a couple places we could refactor some helper functions to make them more versatile (like the helper for outputting to local dir). Since this is a big move, I think those things can be cleaned up later, so this PR LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Improve integration test reliability.
Testing