Repository navigation
feat: mark ActionHelpers interaction shortcuts as deprecated - #1333
Open
hoanle0126 wants to merge 1 commit into
Open
hoanle0126 wants to merge 1 commit into
hoanle0126 wants to merge 1 commit into
Conversation
KazuCocoa
reviewed
Oct 31, 2026
| @@ -0,0 +1,81 @@ | |||
| #!/usr/bin/env python | |||
Member
There was a problem hiding this comment.
Not necessary for the annotation
Contributor
Author
There was a problem hiding this comment.
Removed test/unit/webdriver/device/action_helpers_test.py in e0bcdde.
Comment on lines
+151
to
+163
| Or use native `mobile:` gesture commands via `driver.execute_script`: | ||
|
|
||
| ```python | ||
| # iOS (XCUITest) scroll example | ||
| driver.execute_script('mobile: scroll', {'direction': 'down'}) | ||
| # Android (UiAutomator2) scrollGesture example | ||
| driver.execute_script( | ||
| 'mobile: scrollGesture', | ||
| {'left': 100, 'top': 100, 'width': 200, 'height': 400, 'direction': 'down', 'percent': 1.0}, | ||
| ) | ||
| ``` | ||
|
|
Member
There was a problem hiding this comment.
Can be removed. General recommendation is w3c actions
Contributor
Author
There was a problem hiding this comment.
Removed the mobile: example block in e0bcdde so the section focuses on W3C actions.
hoanle0126
force-pushed
the
feat/deprecate-action-helpers-671
branch
from
October 31, 2026 06:01
86a2042 to
e0bcdde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marks the interaction shortcut methods on
ActionHelpers(scroll,drag_and_drop,tap,swipe, andflick) as deprecated via@deprecated(typing_extensions) and Sphinx.. deprecated::docstrings, and expands the README section with examples of building W3C actions (ActionChains/ActionBuilder) and using driver-specificmobile:gesture commands.Closes #671
Changes
scroll,drag_and_drop,tap,swipe, andflickwith@deprecatedso callers receive both static type-checker warnings and runtimeDeprecationWarnings.ActionChains/ActionBuilderpointer setup andmobile:gestureexecute_scriptusage inREADME.md.test/unit/webdriver/device/action_helpers_test.pyverifying the deprecation warnings and W3C action payloads.