Skip to content

chore(finder): migrate from TSLint to ESLint - #900

Open
noritaka1166 wants to merge 1 commit into
appium:mainfrom
noritaka1166:chore/migrate-finder-lint-to-eslint
Open

chore(finder): migrate from TSLint to ESLint#900
noritaka1166 wants to merge 1 commit into
appium:mainfrom
noritaka1166:chore/migrate-finder-lint-to-eslint

Conversation

@noritaka1166

Copy link
Copy Markdown
Contributor

Summary

  • Migrated static analysis in finder/nodejs from deprecated TSLint to ESLint
  • Added the shared Appium ESLint configuration
  • Updated to ESLint 10.7 and aligned existing code with its rules
  • Removed the TSLint configuration and disable comment

Validation

  • npm run lint
  • npm test
  • npm run compile

@mykola-mokhnach

Copy link
Copy Markdown
Contributor

Thank you for the PR @noritaka1166

We plan to transition all repos to oxc tools and drop the javascript linter because of its slowness. Check appium/appium#22489 for more details.
I will start switching all repos to it as soon as the above module is published.

There is though another prerequisite: since these config packages are native ESM then this package must be also migrated to ESM first. Check, for example, appium/appium-adb#894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants