fix: prefer chromedriverPorts pool over single chromedriverPort when both are set#1076
Open
AsijitM wants to merge 1 commit into
Open
fix: prefer chromedriverPorts pool over single chromedriverPort when both are set#1076AsijitM wants to merge 1 commit into
AsijitM wants to merge 1 commit into
Conversation
…both are set When a caller supplies both the deprecated single `chromedriverPort` and the `chromedriverPorts` pool/range, the single port currently wins and the pool is silently ignored. That makes it impossible to guarantee a free port is picked from the configured pool (e.g. when several parallel sessions share a host). Prefer the `chromedriverPorts` pool when both are provided; behavior is unchanged when only one of them is set. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
setupNewChromedriverresolves the chromedriver port like this:If a caller provides both the single
chromedriverPortand thechromedriverPortspool/range, the single port wins and the configured pool is silently ignored. There is then
no way to guarantee that a session picks a free port from the pool — which matters when
several parallel sessions run against the same host and rely on the pool to avoid collisions.
Fix
When both are provided, prefer a free port from the
chromedriverPortspool and log that thesingle
chromedriverPortis being ignored. Behavior is unchanged when only one of the two is set:chromedriverPort→ use it (as before)chromedriverPorts→ pick from the pool (as before)Notes
setupNewChromedriver; no capability/schema changes.