Skip to content

fix: use double instead of CGFloat for mjpegScalingFactor public API #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 1 commit into from
Jul 12, 2026
+5 −5
Merged

fix: use double instead of CGFloat for mjpegScalingFactor public API #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions WebDriverAgentLib/Utilities/FBConfiguration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ extern NSString *const FBSnapshotMaxDepthKey;
! Setting this to a value less than 100, especially together with orientation fixing enabled
! may lead to WDA process termination because of an excessive CPU usage.
*/
+ (CGFloat)mjpegScalingFactor;
+ (void)setMjpegScalingFactor:(CGFloat)scalingFactor;
+ (double)mjpegScalingFactor;
+ (void)setMjpegScalingFactor:(double)scalingFactor;

/**
YES if verbose logging is enabled. NO otherwise.
Expand Down
6 changes: 3 additions & 3 deletions WebDriverAgentLib/Utilities/FBConfiguration.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
static BOOL FBShouldUseSingletonTestManager = YES;
static BOOL FBShouldRespectSystemAlerts = NO;

static CGFloat FBMjpegScalingFactor = 100.0;
static double FBMjpegScalingFactor = 100.0;
static BOOL FBMjpegShouldFixOrientation = NO;
static NSUInteger FBMjpegServerScreenshotQuality = 25;
static NSUInteger FBMjpegServerFramerate = 10;
Expand Down Expand Up @@ -178,12 +178,12 @@ + (UInt64)httpRequestBodySizeLimit
return DefaultHttpRequestBodySizeLimit;
}

+ (CGFloat)mjpegScalingFactor
+ (double)mjpegScalingFactor
{
return FBMjpegScalingFactor;
}

+ (void)setMjpegScalingFactor:(CGFloat)scalingFactor {
+ (void)setMjpegScalingFactor:(double)scalingFactor {
FBMjpegScalingFactor = scalingFactor;
}

Expand Down