fix: use array-form sh to prevent shell injection in pr lane#181
Merged
johnson-wang-appier merged 3 commits intoJun 12, 2026
Merged
Conversation
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
michael-chang-appier
changed the title
johnson-wang-appier
previously approved these changes
Jun 9, 2026
johnson-wang-appier
left a comment
johnson-wang-appier
left a comment
Collaborator
There was a problem hiding this comment.
Approved with static review
…-8831] Fastlane joins a single-array sh argument back into one shell string and runs it via /bin/sh -c, so sh(["git", ...]) was still shell-injectable. Variadic args are passed straight to Open3.popen2e without a shell. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> AI-Ratio: 0.8
johnson-wang-appier
approved these changes
Jun 12, 2026
johnson-wang-appier
deleted the
michael/MT-8831/fix-fastlane-shell-injection
branch
June 12, 2026 01:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sh "git checkout -b #{branch_name}"withsh ["git", "checkout", "-b", branch_name]in theprlanebranch_nameis passed as a literal argument to git, so shell metacharacters can't be interpreted