Conversation
added 2 commits
September 9, 2026 15:06
Extract the search/sort toolbar, filter sheet, empty state, and scroll-visibility hook. Preserve the current discovery interactions and use inline static styling. Declare the @expo/ui dependency used by the native sort menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesign trail discovery around a compact, reusable sort/search/filter toolbar, with platform-specific sorting menus and shared filter behavior.
Closes #29
Toolbar and search
Sorting and Android parity
MenuViewfrom@expo/ui/community/menu.AndroidSortMenuusingexpo-blurand an Android-onlyBlurTargetViewaround the trail list. Update the sort label immediately and use the same close-animation path for selecting the current option, selecting a different option, tapping outside, or pressing Android Back.lightblur tint on Android light mode instead of the greysystemThinMaterialLighttint; preserve the dark-mode material tint.Filter sheet
Reusable components and styling
src/components/SearchFilterControls.tsx: controlled query/sort values, configurable options and labels, search transitions, and filter content/footer integration.src/components/FilterSheet.tsx: reusable modal sheet,FilterSection, andFilterChip.src/components/AndroidSortMenu.tsx: Android-only frosted sort popup.src/components/EmptyState.tsx: configurable icon, message, and optional action.src/hooks/useScrollVisibility.ts: scroll-driven toolbar visibility; this animates the toolbar, not individual trail cards.app/(tabs)/index.tsx. Use inline styling and shared light/dark theme tokens in the extracted UI.@expo/uidependency used by the native iOS sort menu.Validation
npm run typechecknpm run lintgit diff --checkbench/check-android-controls.mjs: logo centering and sheet-bottom coverage fail on the original screenshots and pass on the corrected screenshots.Before and after evidence
Android layout and sorting
Before: the header logo was left-aligned, the filter sheet exposed a gap above the bottom navigation area, and sorting used the Android Material dropdown rather than the iOS-style popup.
After: the header is centered, the filter sheet reaches the bottom with visible footer actions, and sorting uses a rounded, frosted popup anchored to the Sort By control. These changes are Android-only.
Android menu tint — matching capture pair
Before: the material-light tint gave the popup a grey cast.
After: the
lighttint produces a near-white frosted surface while retaining the background blur.Both screenshots were captured with agent-device on the same owned Pixel 9 emulator, Trails route, light theme, portrait orientation, Name sorting, empty search, and the same bundled trail data. The image attachments are pending browser sign-in; no local-only image links are included here.
Local tooling note
The development machine was upgraded from the global
stim-clipackage to globalstim@1.0.0, and this branch's Metro supervisor was restarted successfully on port 8084. This is a local tooling change, not a new app dependency or native-project change. No Expo prebuild was run. The legacy shutdown preserved the owned emulator and its app data.