fix: require pooled Android benchmark emulators - #574
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Android benchmarks still create a fresh AVD for Stim, so they cannot measure emulator reuse. That policy dates to the original Android benchmark, before Android pooling.
Solution
Prepare one parked Android emulator and require Stim to adopt that exact device, matching the existing iOS methodology. Reject missing, running, or incompatible pool state before dispatch and verify the emulator returns to the pool after cleanup. Control still creates a fresh device. Old Android golden state must be prepared again; published results are not changed by this PR.
Test plan
Fixes #573.