Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 0.9.7 - 2026-03-31

* Fix Windows-incompatible Android source discovery in `way-gradle-plugin` by avoiding `SourceDirectorySet.directories` snapshot/provider placeholder paths (e.g. `provider(?)`)
* Rework source input wiring to stay provider/lazy-based until task execution, resolving only real source directories for generation
* Keep existing generation contract and generated output layout while restoring reliable `*Schema`/`*NodeBuilder` generation across Android modules

## 0.9.6 - 2026-03-26

* Rework `way-gradle-plugin` Android source wiring to use typed Gradle/AGP APIs instead of reflection-based source set registration
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ kotlin.native.ignoreDisabledTargets=true

android.useAndroidX=true

versionName=0.9.6
versionName=0.9.7
pomGroupId=ru.kode
pomDescription=Navigation library based on statechart-like node graphs
pomUrl=https://kode.ru
Expand Down
63 changes: 48 additions & 15 deletions way-gradle-plugin/src/main/kotlin/ru/kode/way/gradle/WayPlugin.kt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.tasks.TaskProvider
import org.gradle.util.GradleVersion
import org.gradle.api.provider.Provider
import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension
import org.jetbrains.kotlin.gradle.dsl.KotlinProjectExtension
import org.jetbrains.kotlin.gradle.plugin.KotlinBasePlugin
Expand Down Expand Up @@ -83,12 +84,14 @@ class WayPlugin : Plugin<Project> {

private fun configureTask(task: GenerateClassesTask, sources: List<Source>) {
task.group = "way"
task.include("**/*.dot")
sources.forEach { source ->
val waySourceDirs = source.sourceDirectories.map { sourceDirectory ->
sourceDirectory.resolveWaySourceDir(source.name)
val waySourceDirs = source.sourceDirectories.map { sourceDirectories ->
sourceDirectories.map { sourceDirectory ->
sourceDirectory.resolveWaySourceDir(source.name)
}
}
task.source(waySourceDirs)
task.include("**/*.dot")
}
}

Expand All @@ -100,7 +103,7 @@ class WayPlugin : Plugin<Project> {
return listOf(
Source(
name = "commonMain",
sourceDirectories = commonMain.kotlin.srcDirs.toList(),
sourceDirectories = providers.provider { commonMain.kotlin.srcDirs.toList() },
registerGeneratedDir = { taskProvider ->
commonMain.kotlin.srcDir(taskProvider)
},
Expand All @@ -112,10 +115,13 @@ class WayPlugin : Plugin<Project> {
// Android project
val androidExtension = project.extensions.findByType(CommonExtension::class.java)
if (androidExtension != null) {
// AGP sourceSet.kotlin.directories API changed semantics across versions.
// Kotlin main source set srcDirs is stable and points to src/main/kotlin|java.
val sourceDirectories = findAndroidSourceDirectories(androidExtension)
if (sourceDirectories.isNotEmpty()) {
// Read resolved source roots from srcDirs; directories snapshots can contain
// provider placeholders (e.g. provider(?)) in AGP built-in Kotlin setups.
val sourceDirectories = findAndroidSourceDirectories(
androidExtension = androidExtension,
kotlinExtension = project.extensions.findByType(KotlinProjectExtension::class.java),
)
if (androidExtension.sourceSets.any { sourceSet -> !isWayTestSourceSet(sourceSet.name) }) {
val androidComponents = project.extensions.findByType(AndroidComponentsExtension::class.java)
if (androidComponents != null) {
return listOf(
Expand Down Expand Up @@ -158,7 +164,7 @@ class WayPlugin : Plugin<Project> {
return listOf(
Source(
name = "main",
sourceDirectories = mainSourceSet.kotlin.srcDirs.toList(),
sourceDirectories = providers.provider { mainSourceSet.kotlin.srcDirs.toList() },
registerGeneratedDir = { taskProvider ->
mainSourceSet.kotlin.srcDir(taskProvider)
},
Expand All @@ -177,7 +183,7 @@ class WayPlugin : Plugin<Project> {
return listOf(
Source(
name = "commonTest",
sourceDirectories = commonTest.kotlin.srcDirs.toList(),
sourceDirectories = providers.provider { commonTest.kotlin.srcDirs.toList() },
registerGeneratedDir = { taskProvider ->
commonTest.kotlin.srcDir(taskProvider)
},
Expand All @@ -188,22 +194,31 @@ class WayPlugin : Plugin<Project> {
return emptyList()
}

private fun Project.findAndroidSourceDirectories(androidExtension: CommonExtension): List<File> =
private fun Project.findAndroidSourceDirectories(
androidExtension: CommonExtension,
kotlinExtension: KotlinProjectExtension?,
): Provider<List<File>> = providers.provider {
androidExtension.sourceSets
.asSequence()
.filterNot { sourceSet -> isWayTestSourceSet(sourceSet.name) }
.flatMap { sourceSet ->
sequenceOf(sourceSet.kotlin, sourceSet.java)
.flatMap { sourceDirectorySet -> sourceDirectorySet.directories.asSequence() }
collectAndroidSourceDirectories(
kotlinSourceDirectories = kotlinExtension
?.sourceSets
?.findByName(sourceSet.name)
?.kotlin
?.srcDirs,
javaSourceDirectories = sourceSet.java.directories.asSequence().map(::file).toList(),
).asSequence()
}
.map(::file)
.distinct()
.toList()
}
}

private data class Source(
val name: String,
val sourceDirectories: List<File>,
val sourceDirectories: Provider<List<File>>,
val registerGeneratedDir: (TaskProvider<GenerateClassesTask>) -> Unit = {},
)

Expand All @@ -226,6 +241,24 @@ internal fun File.resolveWaySourceDir(sourceSetName: String): File = when (name)
internal fun isWayTestSourceSet(sourceSetName: String): Boolean = sourceSetName.startsWith("test", ignoreCase = true) ||
sourceSetName.startsWith("androidTest", ignoreCase = true)

internal fun collectAndroidSourceDirectories(
kotlinSourceDirectories: Collection<File>?,
javaSourceDirectories: Collection<File>?,
): List<File> = (
resolveAndroidLanguageSourceDirectories(
sourceDirectories = kotlinSourceDirectories,
) +
resolveAndroidLanguageSourceDirectories(
sourceDirectories = javaSourceDirectories,
)
).distinct()

internal fun resolveAndroidLanguageSourceDirectories(
sourceDirectories: Collection<File>?,
): List<File> = sourceDirectories
.orEmpty()
.distinct()

internal fun registerGeneratedDirInKotlinMainSourceSet(
kotlinExtension: KotlinProjectExtension?,
taskProvider: TaskProvider<GenerateClassesTask>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,23 @@ class WayPluginSourceResolutionTest :
isWayTestSourceSet("release") shouldBe false
}

should("collect resolved android source dirs when they are valid") {
val kotlinDir = File("/tmp/proj-android/feature/login/routing/custom/kotlin")
val javaDir = File("/tmp/proj-android/feature/login/routing/custom/java")

collectAndroidSourceDirectories(
kotlinSourceDirectories = listOf(kotlinDir),
javaSourceDirectories = listOf(javaDir),
) shouldBe listOf(kotlinDir, javaDir)
}

should("return empty source dirs when resolved dirs are unavailable") {
collectAndroidSourceDirectories(
kotlinSourceDirectories = emptyList(),
javaSourceDirectories = null,
) shouldBe emptyList()
}

should("register generated dir in kotlin main source set without reflection") {
val project = ProjectBuilder.builder().build()
project.pluginManager.apply("org.jetbrains.kotlin.jvm")
Expand Down
Loading