refactor(tests): replace mocha & chai with node:test#190
Merged
Conversation
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Owner
|
Good stuff 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the mocha package was a bit outdated (Currently using v10 when v11 exists) same for chai (Currently using v4 when v6 exists).
Those dependencies could be updated, or we could simply use
node:testinstead. The change is almost seamless, asnode:testis mature and cover all the feature used intest/modem_test.jsThe small issue is that we need to update the GitHub workflow, I added the permissions (recommended by GitHub security), and made some small changes to overall improve it.
I tried it on my fork (E.g. axel7083#1)
The
node:testis not available in version < 16, so the version 14.x has been removed from the test matrix and replace with the latest v24. (Node 14 has reached end of life since 16 Feb 2023 (Ref https://endoflife.date/nodejs)