Rm sort for decode gdr - #15
Open
IzacharyI wants to merge 2 commits into
Open
Conversation
Align with AITER's unsorted HIP decode path and drop the unused threshold override, cache resets, and CI environment setting.
IzacharyI
force-pushed
the
rm_sort_for_decode_gdr
branch
from
August 10, 2026 09:20
2ff1772 to
ccb4f9e
Compare
There was a problem hiding this comment.
Pull request overview
Removes obsolete HIP GDN sorted-index handling following the corresponding AITER change.
Changes:
- Removes sort-cache loading, reset hooks, and calls.
- Removes the
HIP_GDN_SORT_IDX_BSbenchmark configuration. - Deletes tests for retired cache-reset behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/registered/attention/test_gdn_aiter_backend.py |
Removes obsolete reset tests. |
scripts/ci/sglang_benchmark_workflow.sh |
Removes the retired environment override. |
python/sglang/srt/layers/attention/linear/kernels/gdn_aiter.py |
Removes sorted-index cache integration. |
python/sglang/srt/layers/attention/linear/gdn_backend.py |
Removes per-step cache resets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Align SGLang with the AITER HIP GDN implementation after removal of the host-side index sorting path.
Related AITER PR: ROCm/aiter#4656
Technical Details
HIP_GDN_SORT_IDX_BSenvironment override.Requires AITER commit
d74ae325d.Test Plan
Test Result
Submission Checklist