Skip to content

ci: pin third-party actions to commit SHAs #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
B4nan merged 1 commit into from
Aug 20, 2026
Merged

ci: pin third-party actions to commit SHAs #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
node-version: [18, 20]
fail-fast: true
steps:
- uses: actions/checkout@v3

@barjin barjin Aug 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we also bump all the actions to their latest compatible versions? Once this is merged, there's no way Renovate (or Dependabot or anyone else) will ever try to update this.

@B4nan B4nan Aug 20, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me double check, I believe renovate should support this too

@barjin barjin Aug 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, cool then, I was just making a guess. If it can be updated automatically, I have no further questions :)

@barjin barjin Aug 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems you're right, apologies for the noise 👍 https://docs.renovatebot.com/modules/manager/github-actions/#digest-pinning-and-updating

@B4nan B4nan Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, both renovate and dependabot supports this shape

on the other hand, looks like we never set up renovate in this repo 🙃 #1 was closed for some reason. and we'd need to update the whitelist of allowed repos, plus we dont enforce min release age here

- uses: actions/setup-node@v3
- uses: actions/checkout@a37ce9120846195fa4ece8f58b268e6043cb2f26 # v3.7.0
- uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3.9.1
with:
node-version: ${{ matrix.node-version }}
- run: yarn install --immutable
Expand All @@ -36,8 +36,8 @@ jobs:
# env:
# NODE_ENV: production
# steps:
# - uses: actions/checkout@v3
# - uses: actions/setup-node@v3
# - uses: actions/checkout@a37ce9120846195fa4ece8f58b268e6043cb2f26 # v3.7.0
# - uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3.9.1
# - run: yarn install --immutable
# - run: yarn run build
# - run: yarn workspace website run build
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/publish-to-npm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v5
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
with:
token: ${{ secrets.APIFY_SERVICE_ACCOUNT_GITHUB_TOKEN }}
fetch-depth: 0

- name: Set up Node.js
uses: actions/setup-node@v6
uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6.5.0
with:
node-version: "24"
package-manager-cache: false
Expand All @@ -53,7 +53,7 @@ jobs:
corepack prepare yarn@stable --activate

- name: Activate cache for Node.js
uses: actions/setup-node@v6
uses: actions/setup-node@249970729cb0ef3589644e2896645e5dc5ba9c38 # v6.5.0
with:
cache: "yarn"

Expand All @@ -73,7 +73,7 @@ jobs:

- name: Commit changes
id: commit
uses: EndBug/add-and-commit@v9
uses: EndBug/add-and-commit@a94899bca583c204427a224a7af87c02f9b325d5 # v9.1.4
with:
author_name: Apify Release Bot
author_email: noreply@apify.com
Expand Down
Loading