Repository navigation
chore(deps): remove unused dependencies - #4207
Merged
Merged
Conversation
Drops dependencies that nothing imports any more, across the packages, the root and the website, and replaces the one remaining use of got (starting an actor run in the E2E tools) with fetch.
B4nan
added
adhoc
apify-service-account
added
the
tested
# Conflicts: # pnpm-lock.yaml
Contributor
Correct me if I'm wrong, but shouldn't |
Member
Author
|
I believe it did, and (I think) you removed that as part of making it (rather) internal, no? Let me check the history, I don't mind exposing it. |
Member
Author
|
It stopped re-exporting it in #4060, and the upgrading guide covers that ("Add So it was on purpose, now the question is if we should revert that or keep it. |
Member
Author
|
@janbuchar I'll merge this in, if we want to re-expose the browser pool, let's make it in a separate PR. |
Contributor
|
@B4nan I was just contemplating this... Let's keep it hidden and see where that leads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes dependencies that nothing imports any more. Each one was checked against the sources, and for the published packages also against the built
dist(including the type declarations).Published packages:
@crawlee/utils:@apify/ps-tree(core has its own implementation now)@crawlee/http:@apify/utilities,@crawlee/core@crawlee/stagehand:@apify/timeout@crawlee/browser,@crawlee/playwright:type-festcrawlee:@crawlee/browser-pool, which the meta-package never imports.@crawlee/impit-clientstays, since it is detected and enabled when installed.Root dev dependencies:
deep-equal,vite-tsconfig-paths,commitlintand@commitlint/config-conventional(there has never been a commitlint config or acommit-msghook in this repo), and the type packages@types/deep-equal,@types/lodash.isequal,@types/inquirer,@types/proper-lockfile,@types/ps-treeand@types/rimraf.gotgoes too. Its last use was one API call intest/e2e/tools.mjsthat starts an actor run, now done withfetch. Theretryoptions there never applied, because got does not retry POST requests by default, so the behavior is the same. This makes #4205 obsolete.Website:
@apify/utilities,axios,buffer,crypto-browserify,process,prop-types,react-lite-youtube-embed,stream-browserify,@apify/tsconfig,fs-extraandpath-browserify. Nothing in the site sources, config or docs content references them, and there is no webpack fallback configured for the polyfills.