ci: Expand abbreviated SHA to full when creating release tag - #7
Merged
Merged
Conversation
The `apify/actions/signed-commit` action outputs an abbreviated commit
SHA, but the git refs API rejects it ("At least 40 characters are
required"), so tag creation failed after a successful NPM publish.
Resolve the full SHA via the commits API before creating the ref.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same bug that broke publishing in apify/apify-oxlint-config#20 — this repo's
publish_to_npm.yamlhas the identical setup.The
apify/actions/signed-commitaction outputs an abbreviated commit SHA, butPOST /git/refsrequires the full 40-character SHA ("At least 40 characters are required"). As a result the release tag creation fails after NPM publish has already succeeded, leaving a published version with no git tag or GitHub release.Fix: resolve the full SHA via the commits API before creating the ref.