feat: modernize tsconfig to >= node 20 - #5
Merged
Merged
Conversation
B4nan
requested changes
Jun 17, 2026
| "lib": ["ESNext"], | ||
| "module": "CommonJS", | ||
| "moduleResolution": "Node", | ||
| "module": "nodenext", |
Member
There was a problem hiding this comment.
i would rather use node20, since nodenext is a moving target
Contributor
Author
There was a problem hiding this comment.
set to node20 and resolution nodenext since those are the matching pair.
| "sourceMap": true, | ||
| "strict": true, | ||
| "target": "ES2019", | ||
| "target": "esnext", |
Member
There was a problem hiding this comment.
same here, lets use ES2023 or similar. we use this config everywhere, including all the public libraries, those are not a good fit for moving targets in general.
Contributor
Author
There was a problem hiding this comment.
set to ES2023 according to the official TS mapping.
Lib modified as well, so it matches
JuanGalilea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates config to match modern node config.
node(node10) asmoduleResolution. Switch tonodenextfor the.jsextension enforcement on imports.nodenext,modulehas to be that as well.targetbumped toesnext(compatible with node >= 22). Additionally,libwas alreadyESNextwhich could have broken on earlier versions of node due to missing polyfills coming from the mismatch oflib = ESNextandtarget = ES2019.bumped minor version since this might be a breaking change for outdated projects