chore: drop deprecated importsNotUsedAsValues option - #3
Merged
Merged
Conversation
The option was removed in TypeScript 5.5 and tsgolint (used by
oxlint --type-aware) refuses to parse tsconfigs that contain it.
Since TS 5.0, its behavior ('remove') has been the default, so
dropping it is a no-op for consumers.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
t-tooling
B4nan
added a commit
to apify/crawlee
that referenced
this pull request
Apr 17, 2026
## Summary Replaces ESLint + Biome with Oxlint + Oxfmt, modeled after [mikro-orm's setup](https://github.com/mikro-orm/mikro-orm). Type-aware linting is enabled via `oxlint-tsgolint` and the `--type-aware` flag. Lint + format coverage spans `packages`, `test`, and `docs`. ## Notable config choices - **`@apify/tsconfig` bumped to `^0.1.2`** — that release (apify/apify-tsconfig#3, apify/apify-tsconfig#4) drops the deprecated `importsNotUsedAsValues` option that `tsgolint` refuses to parse. No local patch needed anymore. - **Root tsconfigs drop `baseUrl`** — `tsgolint` removed support for it. Non-relative imports under `test/*` and the one stray `packages/*` import in `memory-storage` were converted to relative paths so the mappings could be removed entirely. - **Rules that were triggering across existing code** are fully enabled as errors now. Violations fall into two buckets: - Real issues fixed in-place (dead code after `throw`, `let`→`const`, unnecessary template expressions, `.match` → `RegExp#exec`, `stream` → `node:stream`, deprecated `z.ZodSchema` → `z.ZodType`). - Patterns the rule flags pessimistically but that are correct (`Promise.all(arr.map(fn))` where `fn` returns `Awaitable<void>`) — fixed by marking the inner arrow `async`. - **`typescript/no-deprecated` stays at `warn`** — we intentionally use our own deprecated APIs in implementation code (`pseudoUrls`, `experiments.requestLocking` opt-out, puppeteer page-level cookies/postData/target). They're visible but don't block CI. - **`no-misused-promises`** is configured with `{ checksVoidReturn: { arguments: false } }`. Event-listener callbacks (`page.on(..., async)`) and timer callbacks (`setInterval(async () => ...)`) are standard Node patterns and the rule's default behavior is too strict. - **`lint-staged`** runs `oxlint --fix` then `oxfmt --write`. A handful of unsafe auto-fixes (`no-useless-default-assignment` strips destructuring defaults, `return-await` removes `await` keywords, `no-inferrable-types` occasionally strips default values) are turned off so the fixer can run automatically without risk. ## Migration mechanics - `eslint.config.mjs`, `biome.json`, and `tsconfig.eslint.json` are removed. `.oxlintrc.json` + `.oxfmtrc.json` replace them. - CI's lint job runs `yarn lint` + `yarn format:check`. - `oxfmt` is set to 120 columns / 4-space / single quotes / `lf`, matching the previous Biome setup. Markdown/MDX and release-managed files (CHANGELOGs, package.json) are in its ignore list to avoid cosmetic churn. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
barjin
pushed a commit
to apify/crawlee
that referenced
this pull request
Jul 20, 2026
Replaces ESLint + Biome with Oxlint + Oxfmt, modeled after [mikro-orm's setup](https://github.com/mikro-orm/mikro-orm). Type-aware linting is enabled via `oxlint-tsgolint` and the `--type-aware` flag. Lint + format coverage spans `packages`, `test`, and `docs`. - **`@apify/tsconfig` bumped to `^0.1.2`** — that release (apify/apify-tsconfig#3, apify/apify-tsconfig#4) drops the deprecated `importsNotUsedAsValues` option that `tsgolint` refuses to parse. No local patch needed anymore. - **Root tsconfigs drop `baseUrl`** — `tsgolint` removed support for it. Non-relative imports under `test/*` and the one stray `packages/*` import in `memory-storage` were converted to relative paths so the mappings could be removed entirely. - **Rules that were triggering across existing code** are fully enabled as errors now. Violations fall into two buckets: - Real issues fixed in-place (dead code after `throw`, `let`→`const`, unnecessary template expressions, `.match` → `RegExp#exec`, `stream` → `node:stream`, deprecated `z.ZodSchema` → `z.ZodType`). - Patterns the rule flags pessimistically but that are correct (`Promise.all(arr.map(fn))` where `fn` returns `Awaitable<void>`) — fixed by marking the inner arrow `async`. - **`typescript/no-deprecated` stays at `warn`** — we intentionally use our own deprecated APIs in implementation code (`pseudoUrls`, `experiments.requestLocking` opt-out, puppeteer page-level cookies/postData/target). They're visible but don't block CI. - **`no-misused-promises`** is configured with `{ checksVoidReturn: { arguments: false } }`. Event-listener callbacks (`page.on(..., async)`) and timer callbacks (`setInterval(async () => ...)`) are standard Node patterns and the rule's default behavior is too strict. - **`lint-staged`** runs `oxlint --fix` then `oxfmt --write`. A handful of unsafe auto-fixes (`no-useless-default-assignment` strips destructuring defaults, `return-await` removes `await` keywords, `no-inferrable-types` occasionally strips default values) are turned off so the fixer can run automatically without risk. - `eslint.config.mjs`, `biome.json`, and `tsconfig.eslint.json` are removed. `.oxlintrc.json` + `.oxfmtrc.json` replace them. - CI's lint job runs `yarn lint` + `yarn format:check`. - `oxfmt` is set to 120 columns / 4-space / single quotes / `lf`, matching the previous Biome setup. Markdown/MDX and release-managed files (CHANGELOGs, package.json) are in its ignore list to avoid cosmetic churn. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
B4nan
added a commit
to apify/crawlee
that referenced
this pull request
Aug 12, 2026
Replaces ESLint + Biome with Oxlint + Oxfmt, modeled after [mikro-orm's setup](https://github.com/mikro-orm/mikro-orm). Type-aware linting is enabled via `oxlint-tsgolint` and the `--type-aware` flag. Lint + format coverage spans `packages`, `test`, and `docs`. - **`@apify/tsconfig` bumped to `^0.1.2`** — that release (apify/apify-tsconfig#3, apify/apify-tsconfig#4) drops the deprecated `importsNotUsedAsValues` option that `tsgolint` refuses to parse. No local patch needed anymore. - **Root tsconfigs drop `baseUrl`** — `tsgolint` removed support for it. Non-relative imports under `test/*` and the one stray `packages/*` import in `memory-storage` were converted to relative paths so the mappings could be removed entirely. - **Rules that were triggering across existing code** are fully enabled as errors now. Violations fall into two buckets: - Real issues fixed in-place (dead code after `throw`, `let`→`const`, unnecessary template expressions, `.match` → `RegExp#exec`, `stream` → `node:stream`, deprecated `z.ZodSchema` → `z.ZodType`). - Patterns the rule flags pessimistically but that are correct (`Promise.all(arr.map(fn))` where `fn` returns `Awaitable<void>`) — fixed by marking the inner arrow `async`. - **`typescript/no-deprecated` stays at `warn`** — we intentionally use our own deprecated APIs in implementation code (`pseudoUrls`, `experiments.requestLocking` opt-out, puppeteer page-level cookies/postData/target). They're visible but don't block CI. - **`no-misused-promises`** is configured with `{ checksVoidReturn: { arguments: false } }`. Event-listener callbacks (`page.on(..., async)`) and timer callbacks (`setInterval(async () => ...)`) are standard Node patterns and the rule's default behavior is too strict. - **`lint-staged`** runs `oxlint --fix` then `oxfmt --write`. A handful of unsafe auto-fixes (`no-useless-default-assignment` strips destructuring defaults, `return-await` removes `await` keywords, `no-inferrable-types` occasionally strips default values) are turned off so the fixer can run automatically without risk. - `eslint.config.mjs`, `biome.json`, and `tsconfig.eslint.json` are removed. `.oxlintrc.json` + `.oxfmtrc.json` replace them. - CI's lint job runs `yarn lint` + `yarn format:check`. - `oxfmt` is set to 120 columns / 4-space / single quotes / `lf`, matching the previous Biome setup. Markdown/MDX and release-managed files (CHANGELOGs, package.json) are in its ignore list to avoid cosmetic churn. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
B4nan
added a commit
to apify/crawlee
that referenced
this pull request
Aug 18, 2026
Replaces ESLint + Biome with Oxlint + Oxfmt, modeled after [mikro-orm's setup](https://github.com/mikro-orm/mikro-orm). Type-aware linting is enabled via `oxlint-tsgolint` and the `--type-aware` flag. Lint + format coverage spans `packages`, `test`, and `docs`. - **`@apify/tsconfig` bumped to `^0.1.2`** — that release (apify/apify-tsconfig#3, apify/apify-tsconfig#4) drops the deprecated `importsNotUsedAsValues` option that `tsgolint` refuses to parse. No local patch needed anymore. - **Root tsconfigs drop `baseUrl`** — `tsgolint` removed support for it. Non-relative imports under `test/*` and the one stray `packages/*` import in `memory-storage` were converted to relative paths so the mappings could be removed entirely. - **Rules that were triggering across existing code** are fully enabled as errors now. Violations fall into two buckets: - Real issues fixed in-place (dead code after `throw`, `let`→`const`, unnecessary template expressions, `.match` → `RegExp#exec`, `stream` → `node:stream`, deprecated `z.ZodSchema` → `z.ZodType`). - Patterns the rule flags pessimistically but that are correct (`Promise.all(arr.map(fn))` where `fn` returns `Awaitable<void>`) — fixed by marking the inner arrow `async`. - **`typescript/no-deprecated` stays at `warn`** — we intentionally use our own deprecated APIs in implementation code (`pseudoUrls`, `experiments.requestLocking` opt-out, puppeteer page-level cookies/postData/target). They're visible but don't block CI. - **`no-misused-promises`** is configured with `{ checksVoidReturn: { arguments: false } }`. Event-listener callbacks (`page.on(..., async)`) and timer callbacks (`setInterval(async () => ...)`) are standard Node patterns and the rule's default behavior is too strict. - **`lint-staged`** runs `oxlint --fix` then `oxfmt --write`. A handful of unsafe auto-fixes (`no-useless-default-assignment` strips destructuring defaults, `return-await` removes `await` keywords, `no-inferrable-types` occasionally strips default values) are turned off so the fixer can run automatically without risk. - `eslint.config.mjs`, `biome.json`, and `tsconfig.eslint.json` are removed. `.oxlintrc.json` + `.oxfmtrc.json` replace them. - CI's lint job runs `yarn lint` + `yarn format:check`. - `oxfmt` is set to 120 columns / 4-space / single quotes / `lf`, matching the previous Biome setup. Markdown/MDX and release-managed files (CHANGELOGs, package.json) are in its ignore list to avoid cosmetic churn. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The `importsNotUsedAsValues` option was deprecated in TypeScript 5.0 and fully removed in newer toolchains (e.g. `tsgolint`, which powers `oxlint --type-aware`, refuses to parse tsconfigs that contain it).
Since TS 5.0, the value `"remove"` has been the default behavior, so dropping it from this shared config is a no-op for consumers on any supported TypeScript version. It only removes a compat headache.
A new release after merging would unblock Crawlee v4 (apify/crawlee#3569) from migrating to oxlint with type-aware linting enabled without having to carry a local yarn patch.