feat(utilities): forbid usernames ending in .md - #706
Merged
Merged
Conversation
marekh19
added
the
t-web
marekh19
marked this pull request as ready for review
September 16, 2026 11:49
apify-service-account
added
the
tested
webrdaniel
approved these changes
Sep 16, 2026
B4nan
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of apify/apify-web#6604
Replaces the
AGENTS.md,CLAUDE.mdandauth.mdentries in the forbidden username list with a single(.*\.md)pattern, so no new username can end in.md. apify.com serves a markdown twin of many pages at<path>.md, so such a username collides with that route.We have only a 1 production username ending in
.mdwith a public profile. I will create an exception on the web for that user.Deliberately not added to
USERNAME.REGEX. That regex runs on every user-record write through core'sUserIdentitySchema, so it would invalidate the 20+ existing accounts whose username already ends in.md. By contrastisForbiddenUsername()runs only when a username is picked or changed, invalidateUsername(), which org creation also goes through. Existing holders keep their username and need no migration.