test: drop incorrect schema-hint assertion on --input file-path error#1235
Merged
Conversation
…error
The --input file-path error ("use --input-file instead") is a usage
error, not a schema problem, so the schema-discovery hint intentionally
does not apply there. The test added in #1212 wrongly asserted the hint
was present, failing on CI. Update the test to assert the hint is
absent for this case.
Closes #1234
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
patrikbraborec
force-pushed
the
fix/input-path-error-schema-hint
branch
from
98010af to
f54a224
Compare
patrikbraborec
changed the title
l2ysho
approved these changes
Jun 29, 2026
l2ysho
left a comment
l2ysho
left a comment
Contributor
There was a problem hiding this comment.
👍 Just nit, I would use ci or test or chore (probably this is the one) prefix in commit title instead of fix. fix would be part of changelog (no need to bother user with this change)
patrikbraborec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI test failure introduced in #1212.
The
--inputfile-path error ingetInputOverride("Providing a JSON file path in the --input flag is not supported. Use the--input-file=flag instead") is a usage error, so the schema-discovery hint intentionally does not apply to it — it only makes sense for the parse-error and object-shape-error cases. The test, however, asserted the hint was present for the file-path case and failed on CI.Change
Update the test to assert the schema hint is absent for the file-path error. No source change — the existing behavior is correct.
Testing
pnpm run lint && pnpm run format && pnpm run buildall pass. The only failures in the full local suite are the pre-existing, environment-dependent[python]Actor-execution tests, unrelated to this change.Closes #1234
🤖 Generated with Claude Code