build: move repo to prettier 3.9.x (fix template format:check drift)#827
Merged
Conversation
DaveHanns
force-pushed
the
chore/format-agents-md
branch
from
7758a84 to
dd148fd
Compare
DaveHanns
changed the title
DaveHanns
force-pushed
the
chore/format-agents-md
branch
from
dd148fd to
0131763
Compare
DaveHanns
changed the title
DaveHanns
force-pushed
the
chore/format-agents-md
branch
from
0131763 to
4d91748
Compare
DaveHanns
changed the title
DaveHanns
force-pushed
the
chore/format-agents-md
branch
from
4d91748 to
b12efb0
Compare
DaveHanns
changed the title
The per-template `format:check` (run in CI by the Node template test jobs)
was failing because the repo root and the templates ran different prettier
versions:
- the repo root pins prettier 3.8.3 via pnpm-lock.yaml (range `^3.7.4`), so it
never drifted;
- each template declares prettier as an open `^` range with NO lockfile, so a
fresh `npm install` floats to the newest available — 3.9.x.
Prettier 3.9.0 (2026-06-27) reformats the comment-only objects in the AGENTS.md
input/output schema snippets, so the templates' 3.9.x considered the committed
files mis-formatted while the root's 3.8.3 considered them fine — a version
disagreement, not a real formatting problem.
Move the repo root onto the latest prettier and reformat, so the root and the
templates' floating installs agree:
- bump prettier to 3.9.1 (3.9.2/3.9.3 are blocked by the repo's 24h
`minimumReleaseAge` policy; the templates' npm install floats to 3.9.3, which
produces identical output for these files — verified);
- reformat with it. The ONLY content change is the AGENTS.md schema snippets
collapsing onto one line (`"properties": {/* ... */}`); no other files change.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
DaveHanns
force-pushed
the
chore/format-agents-md
branch
from
b12efb0 to
bd7ed86
Compare
DaveHanns
changed the title
vladfrangu
approved these changes
Jun 29, 2026
| "type": "object", | ||
| "schemaVersion": 1, | ||
| "properties": { | ||
| /* define input fields here */ |
Member
There was a problem hiding this comment.
We probably don't want this collapsed right?
Contributor
Author
There was a problem hiding this comment.
I think it does not really matter much for the agents.
Just for a record, this was the issue failing the tests. The older version of prettier (root level) kept it spread, but the newer versions of prettier (template level) marked it as incorrect formatting.
Now both root and template level are at versions that collapse it.
There was a problem hiding this comment.
You can use // comment if you want force it expanded
Contributor
Author
There was a problem hiding this comment.
Thanks @fisker, I was considering it as a possible solution, but decided to not clutter the md files if not really necessary. As these are supposed to be read mainly by agents, the one-liner is not really an issue.
l2ysho
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: prettier version drift between root and templates
The per-template
format:check(run in CI by Test Node.js templates / Test LLM AI Node.js templates) started failing on every PR run on/after 2026-06-27 (e.g. #824) due to a version mismatch:^3.7.4pnpm-lock.yaml^3.5.3npm installfloats to newest)Prettier 3.9.0 (2026-06-27) reformats the comment-only objects in the
AGENTS.mdinput/output schema snippets. So the templates' 3.9.x flagged files that the root's pinned 3.8.3 considers correctly formatted.Fix: put the whole repo on prettier 3.9.x
Bump the root prettier and reformat, so the root and the templates' floating installs agree.
Notes
Root lands on 3.9.1, not 3.9.3 — the repo's
minimumReleaseAge: 1440(24h) blocks 3.9.2/3.9.3 (released today). The templates' npm install has no such policy and floats to 3.9.3; 3.9.1 and 3.9.3 produce identical output for these files (verified). They'll converge once 3.9.3 is >24h old.The templates still float (
^, no lockfile), so a future prettier release that changes formatting can re-introduce this for the templates (the root is shielded by its lockfile until bumped deliberately).