FDN-4939: Download environment-provider.jar in Dockerfile runtime stage#971
Merged
jackl merged 2 commits intoMay 20, 2026
Merged
Conversation
The jar was removed from the play_builder_java17 image in flowcommerce/docker@458061b. Download it directly in the runtime stage so deployments are not broken. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environment-provider.jarwas removed from theflowcommerce/play_builder_java17image in flowcommerce/docker@458061b, breaking image builds that rely on it at runtime.api/Dockerfileandapp/Dockerfilenow download the jar directly in the runtime stage, removing the dependency on the builder image bundling it.test -sensures a failed or empty download causes a hard build failure rather than a silent runtime crash.Dependencies
None.
Validation
apiandappimagesenvironment-provider.jaris present at/root/environment-provider.jarEng-Review Summary
Title: Unversioned CDN URL — builds not pinned
Resolution: justified
Justification: Matches original upstream behaviour in flowcommerce/docker; always fetching latest environment-provider is intentional.
Title: wget binary assumed present in base image
Resolution: justified
Justification: play_java17 is based on eclipse-temurin:17-jre-jammy (Ubuntu Jammy), which ships wget by default.