[#1823] fix(test): Fix flaky ShuffleBufferManagerTest.shuffleFlushThreshold#2773
Open
wForget wants to merge 1 commit into
Open
[#1823] fix(test): Fix flaky ShuffleBufferManagerTest.shuffleFlushThreshold#2773wForget wants to merge 1 commit into
ShuffleBufferManagerTest.shuffleFlushThreshold#2773wForget wants to merge 1 commit into
Conversation
wForget
changed the title
ShuffleBufferManagerTest.shuffleFlushThresholdShuffleBufferManagerTest.shuffleFlushThreshold
wForget
commented
Jul 23, 2026
| shuffleBufferManager.cacheShuffleData(appId, shuffleId, false, createData(0, 64)); | ||
| assertEquals(96, shuffleBufferManager.getUsedMemory()); | ||
| shuffleBufferManager.cacheShuffleData(appId, smallShuffleId, false, createData(0, 31)); | ||
| assertEquals(96 + 63, shuffleBufferManager.getUsedMemory()); |
Member
Author
There was a problem hiding this comment.
The flush might have already been completed before this assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed?
Replace transient memory assertions and fixed sleeps in
ShuffleBufferManagerTest.shuffleFlushThresholdwith Awaitility-based assertions that wait for stableusedMemoryandinFlushSizevalues.closes #1823
Why are the changes needed?
The asynchronous flush may complete before the test checks the intermediate memory usage, causing failures such as:
The previous assertions depended on thread scheduling, while fixed sleeps could not guarantee that flush cleanup had completed.
How was this patch tested?
Existing test.
Generated by Codex (GPT-5.6)