Skip to content

[MetaScheduler] Improve print info about builder/runner state#19767

Merged
tqchen merged 1 commit into
apache:mainfrom
cbalint13:ms-printer
Jun 14, 2026
Merged

[MetaScheduler] Improve print info about builder/runner state#19767
tqchen merged 1 commit into
apache:mainfrom
cbalint13:ms-printer

Conversation

@cbalint13

@cbalint13 cbalint13 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Adds on-screen info about samples failed to build, that may happen in early stages.


Before:

2026-06-14 18:36:30 [INFO] [task_scheduler.cc:196] TaskScheduler picks Task #0: "dense"
2026-06-14 18:36:32 [INFO] [task_scheduler.cc:209] Sending 64 sample(s) to builder
2026-06-14 18:38:47 [INFO] [task_scheduler.cc:211] Sending 64 sample(s) to runner

After:

2026-06-14 19:53:23 [INFO] [task_scheduler.cc:193] TaskScheduler picks Task #0: "dense"
2026-06-14 19:53:25 [INFO] [task_scheduler.cc:206] Sending 64 sample(s) to builder
2026-06-14 19:55:39 [INFO] [task_scheduler.cc:215] Build errors: 64 sample(s)
2026-06-14 19:55:39 [INFO] [task_scheduler.cc:217] Sending 0 valid sample(s) to runner

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the task scheduler to count and log build errors before sending samples to the runner. The review feedback points out an efficiency issue where task->builder_results.value() is repeatedly called inside a loop, and suggests extracting it to a local reference variable before the loop to avoid redundant unwrapping and reference counting.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/s_tir/meta_schedule/task_scheduler/task_scheduler.cc
@tqchen tqchen merged commit 4b7b7de into apache:main Jun 14, 2026
10 checks passed
@cbalint13 cbalint13 deleted the ms-printer branch June 14, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants