[CI] Drop redundant cmake/ninja install from the Linux wheel CUDA sidecar#19761
Conversation
…ecar Follow-up to the manylinux_cuda image switch. The prebuilt quay.io/manylinux_cuda image already ships cmake (4.3.2, well above the required 3.18) and make, and the sidecar's cmake invocation uses the default Makefiles generator (no -G Ninja), so Ninja was never used. Remove the now-redundant `pip install -U pip cmake ninja` and the unused python_bin variable, and update the comment to match: the image provides the build tools, and PATH only needs the bundled CPython (for the configure) plus the CUDA toolchain (for nvcc). Verified by running the script in the image with no pip install: it configures with the image cmake, builds via make, and produces a libtvm_runtime_cuda.so byte-for-byte the same size as before, still NEEDED libcudart.so.13 with RUNPATH $ORIGIN. Also fix a stale comment in the Windows sidecar: it claimed the conda 13.0.2 pin matched the Linux hook, but the Linux side is now CUDA 13.1 (from the image). The win-64 nvidia channel still caps at 13.0.x, so Windows stays on 13.0.2 -- slightly behind Linux but harmless, since the sidecar has no device code and links the CUDA runtime by soname only. The Windows pip install is kept: that build uses the Ninja generator and runs on a runner without the prebuilt CUDA image.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CI packaging scripts and documentation for building the CUDA runtime sidecar. Specifically, it updates the README to reflect the use of the prebuilt quay.io/manylinux_cuda image and the installation of the CUDA toolkit via conda on Windows. In the Linux build script, it removes redundant installations of pip, cmake, and ninja, relying instead on the prebuilt image's tools. It also updates comments in the Windows build script to clarify CUDA version pinning. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
2 participants
This pr is the follow-up pr of #19754. It removes the redundant
pip install -U pip cmake ninja(since those are already installed in docker) and the unused python_bin variable, and update the comment to match: the image provides the build tools, and PATH only needs the bundled CPython (for the configure) plus the CUDA toolchain (for nvcc).Also fixs a stale comment in the Windows sidecar: it claimed the conda 13.0.2 pin matched the Linux hook, but the Linux side is now CUDA 13.1 (from the image). The win-64 nvidia channel still caps at 13.0.x, so Windows stays on 13.0.2 -- slightly behind Linux but harmless, since the sidecar has no device code and links the CUDA runtime by soname only. The Windows pip install is kept: that build uses the Ninja generator and runs on a runner without the prebuilt CUDA image.