Skip to content

[REFACTOR][DataType] Phase out target custom datatype support#19760

Merged
tqchen merged 1 commit into
apache:mainfrom
tqchen:tvm-phase-out-target-datatype
Jun 14, 2026
Merged

[REFACTOR][DataType] Phase out target custom datatype support#19760
tqchen merged 1 commit into
apache:mainfrom
tqchen:tvm-phase-out-target-datatype

Conversation

@tqchen

@tqchen tqchen commented Jun 14, 2026

Copy link
Copy Markdown
Member

Summary

The in-tree target custom datatype path adds maintenance surface while current development focuses on core datatypes. This PR phases out the built-in registry/lowering implementation and keeps the core dtype behavior intact.

  • Remove the target/datatype implementation, BYODT posit build option, and related Python helpers
  • Remove the custom datatype lowering pass from TIRX and S-TIR finalization pipelines
  • Simplify remaining TIRX dtype handling back to built-in/core datatypes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request completely removes the "Bring Your Own Datatypes" (BYODT) custom datatype framework from TVM, including its CMake configurations, Docker dependencies, Python bindings, C++ registry, custom datatype lowering passes, and associated third-party wrappers. Feedback on the changes suggests that the check for DataType::kCustomBegin in src/target/llvm/codegen_llvm.cc was missed and should be removed as it is now obsolete.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +600 to +601
// LLVM IR doesn't allow void*, so pointer element types that do not
// have an LLVM scalar equivalent need explicit handling.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While updating this comment to reflect the removal of custom datatypes, the check on line 603 (primtype->dtype.code() >= DataType::kCustomBegin) should also be removed as it is now obsolete.

@tqchen tqchen force-pushed the tvm-phase-out-target-datatype branch from eb6b860 to d39af58 Compare June 14, 2026 11:44
@tqchen tqchen merged commit e43555f into apache:main Jun 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants