Skip to content

SOLR-16396 | Fixed failing tests - #5187

Merged
epugh merged 3 commits into
apache:mainfrom
jaykay12:test-fixtures
Oct 21, 2026
Merged

epugh merged 3 commits into
apache:mainfrom
jaykay12:test-fixtures

Conversation

@jaykay12

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SOLR-16396

Description

Solution

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

@jaykay12

Copy link
Copy Markdown
Contributor Author

/no-changelog

@jaykay12

jaykay12 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor Author

@epugh can please trigger the workflows for this?

also, looks like testReqHandlerAPIs of TestSolrConfigHandler has become flaky now, it sometimes passes on local but also fails sometimes.
Screenshot 2026-10-21 at 3 06 25 AM
Screenshot 2026-10-21 at 3 10 30 AM

@jaykay12 jaykay12 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review ✅
precommit ✅
these 2 tests run fine on local ✅

@epugh epugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!!🙏

@epugh epugh added this to the 10.x milestone Oct 21, 2026
@epugh epugh self-assigned this Oct 21, 2026
@epugh
epugh merged commit b7518ba into apache:main Oct 21, 2026
4 checks passed
@epugh

epugh commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Thx

@jaykay12
jaykay12 deleted the test-fixtures branch October 21, 2026 09:26
dsmiley pushed a commit that referenced this pull request Oct 22, 2026
nick-boss-tech added a commit to nick-boss-tech/solr that referenced this pull request Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants