Repository navigation
Conversation
Contributor
Author
Local TestingV1 API - http://localhost:8983/solr/techproducts_shard1_replica_n1/replication?command=details
|
github-actions
Bot
added
the
documentation
Contributor
Author
|
@epugh this PR is also almost ready for first round of review, can you please trigger workflows on this? |
Per apis-v2-conventions.adoc's Testing V2 APIs guidance, new v2 endpoints should be exercised through SolrJettyTestRule and the generated SolrJ client. The existing CoreReplicationAPITest coverage for this handler is Mockito-based delegation testing only.
ReplicationDetailsResponse's isLeader/isFollower/replicationEnabled/ isPollingDisabled/isReplicating now use Boolean instead of String, so the v2 JSON API returns proper booleans. V1's command=details has always rendered these as Strings, and the two now share this same data-gathering code, so V2ApiUtils.squashObjectIntoNamedList gains an opt-in stringifyBooleans flag that only the V1 dispatch branch uses - mirroring the GetConfig.getConfig()/getConfigWithInternalNames() pattern of one shared builder with diverging output shapes.
…olr into SOLR-16398-replication-phase1
Contributor
Author
|
5/6 checks passed, Crave CI have failed: https://github.com/apache/solr/actions/runs/39669769551/job/119787758547?pr=5179 with these 2 tests: I verified both locally using the seed value. 
for confirmation, @epugh lets trigger CI checks again if you feel like it. |
Contributor
|
i bumped tests agian |
Contributor
Author
|
all green now! :yay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16398
Description
Add V2 JAX-RS API for replication details
Solution
AI Disclaimer: Used Cursor for Approach formulation, code is fully vetted & reviewed by me.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.