Repository navigation
SOLR-13943: Move testDateMathInStart into its own test class with a polling wait - #5089
Open
nick-boss-tech wants to merge 25 commits into
Open
nick-boss-tech wants to merge 25 commits into
nick-boss-tech wants to merge 25 commits into
Conversation
….addDocsAndCommit and re-enable the test Hypothetical, unrun regression test; see SOLR-13696-TESTING.md.
…defines Category tests used ship_name_en, which the server _default configset never defines, so autoCreateFields=false rejects every document. Use the string dynamic field ship_name_s. The explicit commit now fails with a clear message if the alias is not listed, instead of a null dereference.
…alias message for dimensional aliases
…lues instead of casting it to Date
…to now in the dimensional routed alias test
…l routed alias placement check
…rovider for the rewritten router start Hypothetical, unrun regression test; see SOLR-13943-TESTING.md.
…artTest so it runs in normal mode
nick-boss-tech
changed the title
nick-boss-tech
marked this pull request as ready for review
October 9, 2026 23:26
nick-boss-tech
added a commit
to nick-boss-tech/solr
that referenced
this pull request
Oct 15, 2026
…ses; corrects the apache#5090 seed to apache#5089)
…ing it mid-creation
…unt, and remove the class-level skip
…instead of dropping it
…the literal myalias
nick-boss-tech
added a commit
to nick-boss-tech/solr
that referenced
this pull request
Oct 18, 2026
…constant in the 11-03 check
…st hold # Conflicts: # solr/core/src/test/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖 (posted on behalf of Nick Shanin)
https://issues.apache.org/jira/browse/SOLR-13943
What happens today
testDateMathInStartdoes not run in normal CI. When it runs, it waits on the test's own ZooKeeper watcher.The method sits in
TimeRoutedAliasUpdateProcessorTest. That class has a class-level@AwaitsFixfor SOLR-13059 (annotation), so its methods are skipped in normal mode. The method also had its own@AwaitsFixfor SOLR-13943.After the add, the test waits on a latch that counts down when its own watcher on
/aliases.jsonfires. Then it reads the start value from the cluster state provider.What this change does
The test moves to its own class with no skip annotation. Its second wait now polls the provider.
1d0b8a0a73cd, which is an ancestor of this head. Until SOLR-13696 lands, this PR's diff against main also shows that PR's production and test changes (TimeRoutedAlias.java,CreateAlias.java, and the routed-alias test files).TimeRoutedAliasDateMathInStartTest, a new class. It has the same base class and no@AwaitsFix(class). The test is at L84-L160.TimeRoutedAliasDateMathInStartTest.java, andTimeRoutedAliasUpdateProcessorTest.java.Proof
The moved test passes in normal mode, and the nearby suites pass too.
receipts/SOLR-13943.mdon coordination): tidy and Error Prone compile pass. In normal mode,TimeRoutedAliasDateMathInStartTestpasses 2 of 2 with no skip,TimeRoutedAliasUpdateProcessorTestpasses 12 with 2 skipped (bothtestDateMathInStart, which this PR moves), and Category 12, Dimensional 4 and CreateAliasAPI 26 pass, with 0 failures.:solr:core:check -x testpasses.TimeRoutedAliasDateMathInStartTesttestDateMathInStart: 1 of 1 in normal mode.CategoryRoutedAliasUpdateProcessorTest6 of 6,DimensionalRoutedAliasUpdateProcessorTest2 of 2, andCreateAliasAPITest13 of 13.These counts are from runs at this head.
At the earlier head
cc155cf68e1d(2026-10-09), with theawaitsfixgroup enabled,TimeRoutedAliasUpdateProcessorTestruns six tests. Five pass.testPreemptiveCreationfails. The change does not touch that test. The failure is the pre-existing timing race that the method's comment describes (assertion).Limits
SOLR-13059 is fixed on the SOLR-13696 branch. PR 5088 (head 960355f) removes the class-level skip. This branch merges that head at aa14590, so the annotation is removed here too.
TimeRoutedAliasUpdateProcessorTestrun in normal mode on this head. No further change is planned.960355fce3ataa14590303. It is a merge, not a rebase, so no history was rewritten. Until PR 5088 lands, the PR diff against main includes the SOLR-13696 and SOLR-13059 commits. When PR 5088 lands, the diff shrinks to this PR's own commits.Changelog:
changelog/unreleased/SOLR-13943.yml(restored byte-identical at this head).AI assistance
AI agents assisted with research, implementation, review, and drafting. Nick Shanin directed the work and takes responsibility for this contribution.