Make AI conversation cold-stage reads opt-in - #14079
Merged
Merged
Conversation
wankai123
approved these changes
Sep 14, 2026
wu-sheng
force-pushed
the
fix/ai-conversation-cold-stage
branch
from
September 14, 2026 05:20
d1f4bf8 to
28949a0
Compare
wankai123
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix AI conversation queries implicitly reading cold storage
When BanyanDB cold storage was configured, opening an AI conversation or exporting its raw files queried both the default stages and cold, even when the caller had not selected cold. Every head-round, round-window, and session-data read now issues one query: omitted/false leaves the stage clause absent, while explicit
coldStage=trueemitsON cold STAGES.The HTTP view accepts an optional
coldStageparameter, and raw-file GraphQL queries acceptConversationCondition.coldStage. The flag is carried through every read; there is no automatic fallback to another stage. The list continues to useDuration.coldStage. Other storage implementations ignore the flag.Uses the merged API from apache/skywalking-query-protocol#174; the protocol submodule points to merged commit
35ae8f2a7662df3d0b9681f635f24bf4e3f23d28.Validation: JDK 17 reactor build covering the conversation module, GraphQL, and all three storage implementations; 22 focused tests passed. Tests cover omitted/false/true HTTP flags, view/export propagation across all windows, no fallback on a missing conversation, and emitted BanyanDB stage clauses with cold storage configured.