Skip to content

Make AI conversation cold-stage reads opt-in - #14079

Merged
wu-sheng merged 1 commit into
masterfrom
fix/ai-conversation-cold-stage
Sep 14, 2026
Merged

wu-sheng merged 1 commit into
masterfrom
fix/ai-conversation-cold-stage

Conversation

@wu-sheng

@wu-sheng wu-sheng commented Sep 14, 2026

Copy link
Copy Markdown
Member

Fix AI conversation queries implicitly reading cold storage

When BanyanDB cold storage was configured, opening an AI conversation or exporting its raw files queried both the default stages and cold, even when the caller had not selected cold. Every head-round, round-window, and session-data read now issues one query: omitted/false leaves the stage clause absent, while explicit coldStage=true emits ON cold STAGES.

The HTTP view accepts an optional coldStage parameter, and raw-file GraphQL queries accept ConversationCondition.coldStage. The flag is carried through every read; there is no automatic fallback to another stage. The list continues to use Duration.coldStage. Other storage implementations ignore the flag.

Uses the merged API from apache/skywalking-query-protocol#174; the protocol submodule points to merged commit 35ae8f2a7662df3d0b9681f635f24bf4e3f23d28.

  • Add unit tests to verify the fix.
  • Explain why the bug exists and how it is fixed.
  • Update documentation and the CHANGES log.

Validation: JDK 17 reactor build covering the conversation module, GraphQL, and all three storage implementations; 22 focused tests passed. Tests cover omitted/false/true HTTP flags, view/export propagation across all windows, no fallback on a missing conversation, and emitted BanyanDB stage clauses with cold storage configured.

@wu-sheng wu-sheng added this to the 11.1.0 milestone Sep 14, 2026
@wu-sheng wu-sheng added the bug Something isn't working and you are sure it's a bug! label Sep 14, 2026
@wu-sheng
wu-sheng force-pushed the fix/ai-conversation-cold-stage branch from d1f4bf8 to 28949a0 Compare September 14, 2026 05:20
@wu-sheng
wu-sheng merged commit 810f3c4 into master Sep 14, 2026
1159 of 1173 checks passed
@wu-sheng
wu-sheng deleted the fix/ai-conversation-cold-stage branch September 14, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working and you are sure it's a bug!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants