Refresh AI agent conversation fixtures for preserved source JSON - #14078
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Move the changelog entry after the existing Project entries to preserve chronological ordering.
Pull request overview
Refreshes AI agent conversation fixtures to match Sessionizer’s preserved raw source JSON output.
Changes:
- Regenerated transcript and round fixtures with updated sizes and digests.
- Updated JSON/YAML views and fixture filename expectations.
- Refreshed test assertions and added a changelog entry.
File summaries
| File | Summary |
|---|---|
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/workspace-changes/transcript-20260101T000000.000000000Z-000001.sd |
Updated workspace transcript fixture. |
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/workspace-changes/r000001-475193a5f44b.sf |
Updated workspace round fixture and digest. |
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/workspace-changes/asz-view-example.yaml |
Updated workspace YAML view. |
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/workspace-changes/asz-view-example.json |
Updated workspace JSON view. |
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/transcript-20260101T000000.000000000Z-000001.sd |
Updated conversation transcript fixture. |
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/r000001-befb6026a577.sf |
Updated round fixture and digest. |
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/asz-view-example.yaml |
Updated YAML view expectations. |
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/asz-view-example.json |
Updated JSON view expectations. |
oap-server/analyzer/ai-agent-conversation/src/test/java/org/apache/skywalking/oap/server/ai/agent/conversation/SessionFormatsTest.java |
Updated size and digest assertions. |
oap-server/analyzer/ai-agent-conversation/src/test/java/org/apache/skywalking/oap/server/ai/agent/conversation/Fixtures.java |
Updated round filenames. |
docs/en/changes/changes.md |
Added the fixture refresh changelog entry. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wu-sheng
force-pushed
the
fix/sessionizer-json-fixtures
branch
from
September 12, 2026 00:20
774e07b to
0a19030
Compare
mrproliu
approved these changes
Sep 12, 2026
wankai123
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix AI agent conversation fixtures that still use re-encoded source JSON
The Sessionizer writer now inserts compacted source JSON without re-encoding it, preserving literal characters such as
&in raw parts. Regenerate both AI agent conversation fixture sets and their JSON/YAML view examples from the Sessionizer fix, using the original fixed scenario time.Update the expected file sizes, digests and round filenames to match. Existing assertions still verify the parsed records, file and chain digests, conversation views and ingestion behavior.
Validation with JDK 11:
SessionFormatsTest,ConversationViewBuilderTestandConversationFileBuilderTestpassed (24 tests, zero failures or errors). Full compile and Javadoc, checkstyle, license headers (zero invalid files) and the changed-Java FQCN audit also passed.CHANGESlog. Not required; this functionality has never been released.