Skip to content

Refresh AI agent conversation fixtures for preserved source JSON - #14078

Merged
wu-sheng merged 1 commit into
apache:masterfrom
wu-sheng:fix/sessionizer-json-fixtures
Sep 12, 2026
Merged

wu-sheng merged 1 commit into
apache:masterfrom
wu-sheng:fix/sessionizer-json-fixtures

Conversation

@wu-sheng

@wu-sheng wu-sheng commented Sep 12, 2026

Copy link
Copy Markdown
Member

Fix AI agent conversation fixtures that still use re-encoded source JSON

The Sessionizer writer now inserts compacted source JSON without re-encoding it, preserving literal characters such as & in raw parts. Regenerate both AI agent conversation fixture sets and their JSON/YAML view examples from the Sessionizer fix, using the original fixed scenario time.

Update the expected file sizes, digests and round filenames to match. Existing assertions still verify the parsed records, file and chain digests, conversation views and ingestion behavior.

  • Add a unit test to verify that the fix works. Existing fixture tests cover this refresh; no additional test case is needed.
  • Explain briefly why the bug exists and how to fix it.

Validation with JDK 11: SessionFormatsTest, ConversationViewBuilderTest and ConversationFileBuilderTest passed (24 tests, zero failures or errors). Full compile and Javadoc, checkstyle, license headers (zero invalid files) and the changed-Java FQCN audit also passed.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Not applicable; no linked issue.
  • Update the CHANGES log. Not required; this functionality has never been released.

@wu-sheng
wu-sheng requested a lite review from Copilot September 12, 2026 00:11
@wu-sheng
wu-sheng marked this pull request as ready for review September 12, 2026 00:13
@wu-sheng wu-sheng added this to the 11.1.0 milestone Sep 12, 2026
@wu-sheng wu-sheng added the bug Something isn't working and you are sure it's a bug! label Sep 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Move the changelog entry after the existing Project entries to preserve chronological ordering.

Pull request overview

Refreshes AI agent conversation fixtures to match Sessionizer’s preserved raw source JSON output.

Changes:

  • Regenerated transcript and round fixtures with updated sizes and digests.
  • Updated JSON/YAML views and fixture filename expectations.
  • Refreshed test assertions and added a changelog entry.
File summaries
File Summary
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/workspace-changes/transcript-20260101T000000.000000000Z-000001.sd Updated workspace transcript fixture.
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/workspace-changes/r000001-475193a5f44b.sf Updated workspace round fixture and digest.
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/workspace-changes/asz-view-example.yaml Updated workspace YAML view.
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/workspace-changes/asz-view-example.json Updated workspace JSON view.
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/transcript-20260101T000000.000000000Z-000001.sd Updated conversation transcript fixture.
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/r000001-befb6026a577.sf Updated round fixture and digest.
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/asz-view-example.yaml Updated YAML view expectations.
oap-server/analyzer/ai-agent-conversation/src/test/resources/fixtures/asz-view-example.json Updated JSON view expectations.
oap-server/analyzer/ai-agent-conversation/src/test/java/org/apache/skywalking/oap/server/ai/agent/conversation/SessionFormatsTest.java Updated size and digest assertions.
oap-server/analyzer/ai-agent-conversation/src/test/java/org/apache/skywalking/oap/server/ai/agent/conversation/Fixtures.java Updated round filenames.
docs/en/changes/changes.md Added the fixture refresh changelog entry.
Review details
  • Files reviewed: 10/10 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@wu-sheng
wu-sheng force-pushed the fix/sessionizer-json-fixtures branch from 774e07b to 0a19030 Compare September 12, 2026 00:20
@wu-sheng
wu-sheng merged commit 25c74a8 into apache:master Sep 12, 2026
466 of 470 checks passed
@wu-sheng
wu-sheng deleted the fix/sessionizer-json-fixtures branch September 12, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working and you are sure it's a bug!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants