Deploy the root java-agent POM to Maven Central - #827
Merged
Conversation
Member
Author
|
Pushed
Happy to split it into its own PR if you would rather keep this one to the POM change. |
#805 set maven.deploy.skip=true in the root POM so that only the toolkit modules reach Maven Central, and re-enabled deployment in apm-application-toolkit. The root POM is itself the parent of apm-application-toolkit, so skipping it broke the parent chain of every published toolkit artifact. 9.7.0, the first release with #805 in it, has all ten apm-toolkit-* artifacts and apm-application-toolkit on Central but no java-agent-9.7.0.pom, and resolving any of them fails: Non-resolvable parent POM for org.apache.skywalking:apm-application-toolkit:9.7.0: Could not find artifact org.apache.skywalking:java-agent:pom:9.7.0 in central Declare maven-deploy-plugin at the root with inherited=false and skip=false. Plugin configuration wins over the maven.deploy.skip property, and inherited=false confines the exception to this POM: apm-commons, apm-protocol and apm-sniffer still skip deployment, while apm-application-toolkit and its children keep opting back in through the property. Also add the missing root POM to the release vote checklist, since the failure is invisible until a user resolves the toolkit from a clean repository. Two unrelated fixes ride along: - apache/skywalking-swck moved docs/java-agent-injector.md to docs/en/setup/java-agent-injector.md and now renders it on the website, so the old GitHub URL 404s. It is the repository's only dead link and it fails the Dead Link Checker on every PR. Point containerization.md at the rendered page, which survives the next reshuffle of the swck source tree. - Spell out in CLAUDE.md that an AI assistant is never credited as an author, and that this overrides any co-author trailer the tool is configured to add. Resolves apache/skywalking#13988
wu-sheng
force-pushed
the
fix/deploy-root-parent-pom
branch
from
September 9, 2026 12:16
93f4ff7 to
2efc0ac
Compare
3 tasks
wankai123
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug
Resolves apache/skywalking#13988
The bug
org.apache.skywalking:java-agent:9.7.0is missing from Maven Central, so every toolkit artifact of 9.7.0 is unresolvable:Reproduce with a clean local repository:
mvn -U -Dmaven.repo.local=$(mktemp -d) \ dependency:get -Dartifact=org.apache.skywalking:apm-toolkit-logback-1.x:9.7.0Status on
repo.maven.apache.orgfor 9.7.0: all tenapm-toolkit-*modules andapm-application-toolkitare present (200);java-agentis 404. The listing under/org/apache/skywalking/java-agent/stops at9.6.0/.Cause
#805 ("Only publish toolkit to Maven Central") set
<maven.deploy.skip>true</maven.deploy.skip>in the root POM and re-enabled deployment inapm-application-toolkit. The root POM is itself the parent ofapm-application-toolkit, so skipping it breaks the parent chain of everything published:9.7.0 (tagged 2026-08-12) is the first release containing #805 (2026-04-11), which matches 9.6.0 resolving and 9.7.0 not.
The fix
Declare
maven-deploy-pluginat the root withinherited=falseandskip=false. Plugin configuration takes precedence over themaven.deploy.skipproperty, andinherited=falseconfines the exception to the root POM.Verified against the effective POMs:
maven.deploy.skip<skip>java-agent(root)truefalseapm-commons,apm-protocol,apm-sniffertrueapm-application-toolkit+ toolkit modulesfalseand by running
./mvnw -N deploy -DaltDeploymentRepository=local::default::file://..., which now uploadsjava-agent-9.8.0-SNAPSHOT.pom.The release vote checklist gains the corresponding item, since this failure is invisible during the release — the staged artifacts all look fine, and only a user resolving from a clean repository hits it.
Note on 9.7.0
This fix only covers 9.8.0 onward. 9.7.0 stays broken until
java-agent:9.7.0:pom, built from thev9.7.0tag, is staged and released separately. That coordinate was never published, so it is an addition rather than a modification of a released artifact.CHANGES.md.