[GH-3329] Preserve WKB dimensions in Arrow export - #3332
Closed
ryux1 wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for creating this PR. the correct fix should be in this PR #3335 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
The applicable contributor rules and Python development instructions were checked during delegated preparation.
Is this PR related to a ticket?
Yes. Closes #3329.
What changes were proposed in this PR?
For WKB encoding, collect the canonical output of
GeoSeries.to_wkb()before delegating Arrow construction to GeoPandas. This avoids a GeometryType-to-Python round trip that can infer a Z dimension for a 2D GeometryCollection whose typed members are all empty. Native GeoArrow encoding continues to use the existing path.The shared parity fixture now includes
GeometryCollection([Point(), LineString(), Polygon()]), reproducing the case removed from #3326 and verifying that Sedona matches GeoPandas.How was this patch tested?
TestMatchGeopandasSeries::test_to_arrowTestMatchGeopandasSeries::test_to_wkbTestGeoSeries::test_to_arrowgit diff --checkDid this PR include necessary documentation updates?
No. This fixes serialization behavior without changing the public API.