[ISSUE #10582] Fix POP revive offset comparator overflow

[Aias00]

Which Issue(s) This PR Fixes

• Fixes [Bug] POP revive checkpoints may be processed out of order due to reviveOffset comparator overflow #10582

Brief Description

This PR fixes the POP revive checkpoint ordering comparator in PopReviveService.ConsumeReviveObj#genSortList().

The previous implementation subtracted two long reviveOffset values and cast the result to int:

sortList.sort((o1, o2) -> (int) (o1.getReviveOffset() - o2.getReviveOffset()));

When the offset gap is larger than Integer.MAX_VALUE, the cast can overflow and return the wrong ordering. Since the sorted checkpoint list is consumed by mergeAndRevive(), this can cause POP revive checkpoints to be processed out of order.

The comparator now uses Comparator.comparingLong(PopCheckPoint::getReviveOffset) so the full long value is compared safely. A regression test covers two checkpoints whose revive offsets differ by more than Integer.MAX_VALUE.

How Did You Test This Change?

• mvn -pl broker -Dtest=PopReviveServiceTest test -Dspotbugs.skip=true -Dcheckstyle.skip=true
• git diff --check

[Copilot]

Pull request overview

Fixes incorrect POP revive checkpoint ordering caused by an overflow-prone comparator in PopReviveService.ConsumeReviveObj#genSortList(), ensuring revive offsets are always sorted by their full long value.

Changes:

• Replaced (int) (o1.getReviveOffset() - o2.getReviveOffset()) comparator with Comparator.comparingLong(PopCheckPoint::getReviveOffset) to prevent overflow and wrong ordering.
• Added a regression test covering revive offsets that differ by more than Integer.MAX_VALUE.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java	Uses a safe long comparator to sort revive checkpoints deterministically without overflow.
broker/src/test/java/org/apache/rocketmq/broker/processor/PopReviveServiceTest.java	Adds a regression test that would fail with the old overflow-prone comparator.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.17%. Comparing base (8242c1e) to head (6434cbd).

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #10583      +/-   ##
=============================================
- Coverage      48.26%   48.17%   -0.10%     
+ Complexity     13433    13411      -22     
=============================================
  Files           1378     1378              
  Lines         100817   100817              
  Branches       13040    13040              
=============================================
- Hits           48660    48564      -96     
- Misses         46211    46292      +81     
- Partials        5946     5961      +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.