Skip to content

[ISSUE #10421] Fix Timer message RocksDB cache key using ByteBuffer #10532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itxaiohanglover wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ISSUE #10421] Fix Timer message RocksDB cache key using ByteBuffer #10532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions store/src/main/java/org/apache/rocketmq/store/rocksdb/MessageRocksDBStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public class MessageRocksDBStorage extends AbstractRocksDBStorage {
private volatile ColumnFamilyHandle transCFHandle;

private final ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1);
private static final Cache<byte[], byte[]> DELETE_KEY_CACHE_FOR_TIMER = CacheBuilder.newBuilder()
private static final Cache<ByteBuffer, byte[]> DELETE_KEY_CACHE_FOR_TIMER = CacheBuilder.newBuilder()
.maximumSize(10000)
.expireAfterWrite(60, TimeUnit.MINUTES)
.build();
Expand Down Expand Up @@ -354,9 +354,9 @@ public void writeRecordsForTimer(byte[] columnFamily, List<TimerRocksDBRecord> r
writeBatch.put(cfHandle, keyBytes, valueBytes);
} else if (record.getActionFlag() == TIMER_ROCKSDB_DELETE) {
writeBatch.delete(cfHandle, keyBytes);
DELETE_KEY_CACHE_FOR_TIMER.put(keyBytes, DELETE_VAL_FLAG);
DELETE_KEY_CACHE_FOR_TIMER.put(ByteBuffer.wrap(keyBytes), DELETE_VAL_FLAG);
} else if (record.getActionFlag() == TIMER_ROCKSDB_UPDATE) {
byte[] deleteByte = DELETE_KEY_CACHE_FOR_TIMER.getIfPresent(keyBytes);
byte[] deleteByte = DELETE_KEY_CACHE_FOR_TIMER.getIfPresent(ByteBuffer.wrap(keyBytes));
if (null == deleteByte) {
writeBatch.put(cfHandle, keyBytes, valueBytes);
}
Expand Down