RATIS-2682. Use the original Raft group for client retries in testKillLeaderDuringReconf - #1578
Merged
Merged
Conversation
…lLeaderDuringReconf.
szetszwo
approved these changes
Sep 3, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
@szetszwo Thanks for the review and for merging the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request fixes a remaining race in
testKillLeaderDuringReconf.The test previously created the Raft client after calling
addNewPeers()andremovePeers(). These methods updatecluster.groupto the target configuration, which may contain the unstarted peer and exclude an originalvoting member that can become the new leader after the original leader is killed.
With
SimulatedRpc, a request sent to the unstarted peer may wait for3seconds before timing out.Repeated retries against that peer can exhaust the test's waiting period before the
setConfigurationrequest reaches the new leader.The test then fails with an error such as:
What is the link to the Apache JIRA
RATIS-2682. Use the original Raft group for client retries in testKillLeaderDuringReconf
How was this patch tested?
The target test passed 100 runs using 10 parallel splits with 10 iterations per split:
https://github.com/slfan1989/ratis/actions/runs/33755713261