Skip to content

RATIS-2677. Replace redundant setFirstRequest() call with an assertion #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szetszwo merged 1 commit into from
Sep 1, 2026
+4 −3
Merged

RATIS-2677. Replace redundant setFirstRequest() call with an assertion #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedAsync.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public void fail(Throwable e) {

@Override
public String toString() {
return "[cid=" + callId + ", seq=" + getSeqNum() + "]";
return "[cid=" + callId + ", seq=" + getSeqNum() + (isFirst? "(1st)": "") + "]";
}
}

Expand Down Expand Up @@ -201,7 +201,8 @@ private void sendRequestWithRetry(PendingOrderedRequest pending) {
}

if (getSlidingWindow(request).isFirst(pending.getSeqNum())) {
pending.setFirstRequest();
Preconditions.assertTrue(request.getSlidingWindowEntry().getIsFirst(),
() -> "The first request is not marked as first: " + request);
}
LOG.debug("{}: send* {}", client.getId(), request);
client.getClientRpc().sendRequestAsync(request).thenAccept(reply -> {
Expand Down
2 changes: 1 addition & 1 deletion ratis-common/src/main/java/org/apache/ratis/util/ProtoUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ static String toString(SlidingWindowEntry proto) {
if (proto == null) {
return null;
}
return proto.getSeqNum() + (proto.getIsFirst()? "*": "");
return proto.getSeqNum() + (proto.getIsFirst()? "(1st)": "");
}

static String toString(RaftRpcRequestProto proto) {
Expand Down
Loading