Skip to content

NO-JIRA: [Python] Do not require wheel for building #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yselkowitz wants to merge 1 commit into from
+1 −3
Closed

NO-JIRA: [Python] Do not require wheel for building #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,10 @@ else ()
endif ()

check_python_module("setuptools" SETUPTOOLS_MODULE_FOUND)
check_python_module("wheel" WHEEL_MODULE_FOUND)
check_python_module("cffi" CFFI_MODULE_FOUND)

if (BUILD_MODULE_FOUND AND
(ENABLE_PYTHON_ISOLATED OR (SETUPTOOLS_MODULE_FOUND AND WHEEL_MODULE_FOUND AND CFFI_MODULE_FOUND)))
(ENABLE_PYTHON_ISOLATED OR (SETUPTOOLS_MODULE_FOUND AND CFFI_MODULE_FOUND)))
if (BUILD_PYTHON_UNBUNDLED_PKG)
add_custom_command(OUTPUT .timestamp.dist
DEPENDS pypkg_src_copied
Expand Down
1 change: 0 additions & 1 deletion python/ci_requirements.txt
View file
Open in desktop

@astitcher astitcher Aug 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that if this PR depends on setuptools 70.1 then this should be in this requirements file!

@yselkowitz yselkowitz Aug 18, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hroncok from your other tickets it was implied that this works with setuptools < 70.1 also?

@hroncok hroncok Aug 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was never needed to be specified as a build backend requires. However, that implies building via the pyproject hooks. I don't know how this file is used here.

@hroncok hroncok Aug 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the cmake file below, that would be the isolated build option.

Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
pip
build
setuptools
wheel
flake8
tox>=1.7.2
cffi>=1.0.0
Loading