Conversation
PR apache#1041 fixed this example in docs/, version-4.0.x, and version-4.2.x but missed version-4.1.x, which still shows retryLetterProducerBuilderCustomizer being configured without enableRetry(true).
Author
|
Hi maintainers, could someone please review this when you get a chance? I've checked that there are no failing checks showing on the PR from my side. Happy to make any changes needed. Thank you! |
vjymisal0
force-pushed
the
fix/enable-retry-doc-4.1.x
branch
from
October 3, 2026 18:22
7de4621 to
1be90c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Contribution Checklist
Motivation
#24775 (apache/pulsar) reported that the
DeadLetterPolicyexample usingretryLetterProducerBuilderCustomizerwas missing the required.enableRetry(true)call, which is misleading since retry-letter configuration has no effect without it.#1041 already fixed this in
docs/concepts-messaging.md,versioned_docs/version-4.0.x/concepts-messaging.md, andversioned_docs/version-4.2.x/concepts-messaging.md, but missedversioned_docs/version-4.1.x/concepts-messaging.md, which still has the same gap.Modifications
.enableRetry(true)to the same example inversioned_docs/version-4.1.x/concepts-messaging.md, matching the fix already applied to the other versions.