Add oxia.server.walSyncData to optionally disable WAL fsync for testing#696
Merged
lhotari merged 1 commit intoJun 24, 2026
Merged
Conversation
Add an `oxia.server.walSyncData` value (default "true"). When the key is present and set to false, the oxia server StatefulSet passes `--wal-sync-data=false` so WAL data is not fsynced to disk after each write. The flag is only emitted when the key exists and is explicitly false (string or boolean), so sync data cannot be turned off accidentally by an unset or default value. The flag name matches the oxia 0.16.7 CLI (`--wal-sync-data`, a pflag boolean, hence the `=false` form). Also enable it in examples/values-disable-fsync.yaml and document it there and in examples/README.md alongside the BookKeeper and ZooKeeper fsync toggles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
oxia.server.walSyncDatavalue (default "true"). When the key is present and set to false, the oxia server StatefulSet passes--wal-sync-data=falseso WAL data is not fsynced to disk after each write.The flag is only emitted when the key exists and is explicitly false (string or boolean), so sync data cannot be turned off accidentally by an unset or default value. The flag name matches the oxia 0.16.7 CLI (
--wal-sync-data, a pflag boolean, hence the=falseform).Also enable it in examples/values-disable-fsync.yaml and document it there and in examples/README.md alongside the BookKeeper and ZooKeeper fsync toggles.