MINOR: Use Thrift 0.24.0 in CI - #612
Open
skrcode wants to merge 1 commit into
Open
Conversation
Keep the compiler installed by the test workflow aligned with the libthrift version required by the Maven build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion fix for #597, built on its exact head (3a4b3b4).
Rationale for this change
#597 updates libthrift and the Maven-required compiler version to 0.24.0, but the test workflow still downloads and installs compiler 0.23.0. Maven therefore stops all JDK 8, 11, 17, and 21 lanes with the deterministic version mismatch before compilation.
What changes are included in this PR?
The workflow now downloads the official Thrift 0.24.0 archive and enters the matching source directory. This follows the same two-line alignment used for the prior Thrift upgrade in #570 and commit c670caf.
Do these changes have PoC implementations?
The exact source failure was reproduced with compiler 0.23.0. After building the official 0.24.0 compiler:
AI assistance disclosure: JAIPilot/Codex assisted with diagnosis and verification. The complete one-file diff was reviewed before publication.