fix: scale 4-bit PQ scan lookup tables by the table range - #92
Open
jackylee-ch wants to merge 1 commit into
Open
fix: scale 4-bit PQ scan lookup tables by the table range#92jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scan_4bit_simdbuilds the u8 quantization factor fromqmax, the largest summed distance over the first 200 rows, then applies it to individual table entries. Entries are ~1/m of a sum, so the table collapses into the low255/mof the u8 range and rows past 200 rank worse.fastscan.rsalready scales by the table's own max; this reuses itsquantize_distance_table.Tests:
test_scan_4bit_simd_largefails before this change (row 200 off by 4.04, tolerance 2.80), passes aftercargo test --release --workspace(503 passed)cargo fmt --all -- --checkcargo +1.98.0 clippy --release --all-targets --workspace -- -D warnings