feat: Add DAX, and examples to the Dialects#250
Open
MikeCarlo wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the core Ossie specification to recognize the DAX (Data Analysis Expressions) dialect and adds/updates examples describing how dialect-specific expressions can be represented.
Changes:
- Add
DAXto the standardized dialect enumeration (YAML spec, Markdown spec, and JSON Schema). - Add DAX to the expression language documentation and provide DAX examples/column in the “Common Dialect Variations” table.
- Add
MICROSOFTto the JSON Schema’s vendor example list.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| core-spec/spec.yaml | Adds DAX to the dialect enumeration list. |
| core-spec/spec.md | Documents DAX in the supported dialects table. |
| core-spec/osi-schema.json | Adds DAX to the dialect enum and adds MICROSOFT as a vendor example. |
| core-spec/expression_language.md | Adds DAX to standardized dialect identifiers and expands examples/tables to include DAX. |
Comments suppressed due to low confidence (2)
core-spec/expression_language.md:671
- In the dialect variation table, the PostgreSQL string concatenation example was changed to CONCAT_WS('', a, b). CONCAT_WS has different NULL-handling (skips NULL arguments) and is less representative of the common Postgres concatenation operator shown elsewhere in the spec (e.g., "||").
| String concat | `CONCAT(a, b)` | `CONCAT(a, b)` | `CONCAT(a, b)` | `CONCAT(a, b)` | `CONCAT_WS('', a, b)` | `CONCATENATE(a, b)` or `a & b` |
core-spec/expression_language.md:670
- In the dialect variation table, the DAX entries for date truncation and date add use STARTOFMONTH/DATEADD, which are table-returning functions in DAX. For a scalar expression example (consistent with the other dialect columns), use scalar date construction/arithmetic instead.
| Date truncation | `DATE_TRUNC('month', d)` | `DATE_TRUNC('month', d)` | `DATE_TRUNC(d, MONTH)` | `DATE_TRUNC('month', d)` | `DATE_TRUNC('month', d)` | `STARTOFMONTH(d)` |
| Date add | `DATEADD(day, 7, d)` | `DATEADD(day, 7, d)` | `DATE_ADD(d, INTERVAL 7 DAY)` | `DATE_ADD(d, 7)` | `d + INTERVAL '7 days'` | `DATEADD(d, 7, DAY)` |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
Checklist
Specification
core-spec/and follow the existing structureOntology
ontology/are consistent with spec changesConverters
converters/is updated to reflect spec or ontology changesValidation
validation/are updated if the spec changedDocumentation
docs/is updated to reflect any user-facing changesCONTRIBUTING.mdis updated if the contribution process changedExamples
examples/are added or updated for any new spec constructs or converter supportTests
pytest/ CI green)Compliance