fix(bindings/python): enable hdfs-native on arm#7911
Open
chitralverma wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
size:XS
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR re-enables the hdfs-native service for ARM Python wheels by making services-hdfs-native part of the unconditional services-all feature set and removing the ARM-only exclusion previously applied in the Python bindings.
Changes:
- Add
services-hdfs-nativeto the unconditionalservices-allfeature list. - Remove the target-arch (
arm) conditional feature gating forservices-hdfs-native.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6791.
Rationale for this change
OpenDAL excluded
hdfs-nativefrom ARM Python wheels in #6792 because hdfs-native 0.13.0 contained bindgen layout assertions generated for 64-bit targets. The upstream fix removed those assertions and verified armv7 under QEMU in Kimahriman/hdfs-native#271, resolving Kimahriman/hdfs-native#270. OpenDAL currently resolves hdfs-native 0.13.5, which contains that fix.Related dependency upgrade: #7910 upgrades hdfs-native to 0.14.2. This PR is independent because the ARM fix is already included in 0.13.5.
What changes are included in this PR?
services-hdfs-nativeback to the unconditional Pythonservices-allfeature.Are there any user-facing changes?
Yes. Python wheels built for ARM targets include the hdfs-native service again.
Verification
cargo check --features services-allinbindings/pythonjust lintinbindings/pythonlinux/arm/v7container:cargo check --locked -p opendal-service-hdfs-nativetaplo format --check Cargo.tomlinbindings/pythonAI Usage Statement
This PR was prepared with OpenCode using GPT-5.6.