fix: preserve raw query parameters during signing#782
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
SigningRequest parsed and rebuilt existing URI queries, which could change their encoded wire representation during signing. Preserve unchanged raw query parameters while keeping service-specific canonical queries separate for signature calculation. Closes apache#778. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #778.
SigningRequestpreviously parsed existing URI queries and rebuilt them from decoded pairs. This could change percent-encoded values and even alter query parameter boundaries during signing.This PR preserves unchanged raw query parameters when applying signed requests. Affected signers now use separate canonical query representations for signature calculation without rewriting the query sent over the wire.
Regression tests cover header signing and query signing across affected services