Improved: Retry testIntegration once on non-graceful failure (OFBIZ-13514) - #1837
Open
mridulpathak wants to merge 1 commit into
Open
mridulpathak wants to merge 1 commit into
mridulpathak wants to merge 1 commit into
Conversation
…3514) BuildBot's ofbizTrunkFramework and ofbizBranch24Framework builders have hit sporadic CI-worker contention failures during facilitytests, a different test each time. This adds a single automatic retry to testIntegration, but only when the run does not complete gracefully, meaning a JVM crash, hang, or non-test container startup failure - a run that completes and legitimately reports failing tests still fails immediately, with no retry. TestRunContainer now writes a completion marker once every suite has run to completion, which build.gradle uses to tell the two cases apart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backported from trunk (#1836). TestRunContainer.java needed manual adaptation since release24.09 predates the Jupiter test-engine migration - the same completion-marker fix was applied to its plain JUnit3-based start() loop, and the accompanying unit test was dropped since this branch has no src/test/java tree for the testtools module.