Skip to content

arch/lpc214x: Fix LPC214x to work again#19234

Open
acassis wants to merge 1 commit into
apache:masterfrom
acassis:fix_lpc214x
Open

arch/lpc214x: Fix LPC214x to work again#19234
acassis wants to merge 1 commit into
apache:masterfrom
acassis:fix_lpc214x

Conversation

@acassis

@acassis acassis commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

This fix is based on the same fix for LPC2378, however it wasn't tested on real hardware because I don't have a LPC214x board.

Impact

LPC214x will work again.

Testing

Only tested on LPC2378 board.

This fix is based on the same fix for LPC2378, however it wasn't
tested on real hardware because I don't have a LPC214x board.

Signed-off-by: Alan C. Assis <acassis@gmail.com>
@github-actions github-actions Bot added Arch: arm Issues related to ARM (32-bit) architecture Size: S The size of the change in this PR is small labels Jun 28, 2026
@github-actions

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@xiaoxiang781216

Copy link
Copy Markdown
Contributor

ci error is fixed by apache/nuttx-apps#3568

@simbit18

simbit18 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hi @acassis , The PR apache/nuttx-apps#3568 has been merged. Please rebase.

Update
Since the fix affects the nuttx-apps repository, I had all the jobs run (Re-run all jobs)

@simbit18

Copy link
Copy Markdown
Contributor

Hi @acassis This error occurs

====================================================================================
Configuration/Tool: zp214xpa/nsh,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2026-06-29 07:23:28
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Building NuttX...
In file included from chip/lpc214x_decodeirq.c:36:
chip/lpc214x_decodeirq.c: In function 'arm_decodeirq':
Error: chip/lpc214x_decodeirq.c:152:33: error: 'VIC_IRQSTATUS_OFFSET' undeclared (first use in this function); did you mean 'LPC214X_VIC_IRQSTATUS_OFFSET'?
  152 |   uint32_t irqbits = vic_getreg(VIC_IRQSTATUS_OFFSET) & 0xffffffff;
      |                                 ^~~~~~~~~~~~~~~~~~~~
/github/workspace/sources/nuttx/arch/arm/src/common/arm_internal.h:130:48: note: in definition of macro 'getreg32'
  130 | #define getreg32(a)    (*(volatile uint32_t *)(a))
      |                                                ^
chip/lpc214x_decodeirq.c:152:22: note: in expansion of macro 'vic_getreg'
  152 |   uint32_t irqbits = vic_getreg(VIC_IRQSTATUS_OFFSET) & 0xffffffff;
      |                      ^~~~~~~~~~
chip/lpc214x_decodeirq.c:152:33: note: each undeclared identifier is reported only once for each function it appears in
  152 |   uint32_t irqbits = vic_getreg(VIC_IRQSTATUS_OFFSET) & 0xffffffff;
      |                                 ^~~~~~~~~~~~~~~~~~~~
/github/workspace/sources/nuttx/arch/arm/src/common/arm_internal.h:130:48: note: in definition of macro 'getreg32'
  130 | #define getreg32(a)    (*(volatile uint32_t *)(a))
      |                                                ^
chip/lpc214x_decodeirq.c:152:22: note: in expansion of macro 'vic_getreg'
  152 |   uint32_t irqbits = vic_getreg(VIC_IRQSTATUS_OFFSET) & 0xffffffff;
      |                      ^~~~~~~~~~
chip/lpc214x_decodeirq.c: At top level:
Error: chip/lpc214x_decodeirq.c:81:18: error: 'lpc214x_decodeirq' defined but not used [-Werror=unused-function]
   81 | static uint32_t *lpc214x_decodeirq(uint32_t *regs)
      |                  ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:179: lpc214x_decodeirq.o] Error 1
make[1]: Target 'libarch.a' not remade because of errors.
make: *** [tools/LibTargets.mk:170: arch/arm/src/libarch.a] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 397: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
  [1/1] Normalize zp214xpa/nsh
/github/workspace/sources/nuttx /github/workspace/sources/nuttx
HEAD detached at pull/19234/merge
nothing to commit, working tree clean
/github/workspace/sources/nuttx
/github/workspace/sources/apps /github/workspace/sources/nuttx
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
/github/workspace/sources/nuttx
Wait 4 seconds (60 backoff)
Build Attempt 2 of 4
====================================================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: arm Issues related to ARM (32-bit) architecture Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants