stm32f746g-disco: Fix USERLED support#19232
Merged
Merged
Conversation
Provide correct pin name BOARD_LED1 and associated bit mask BOARD_LED1_BIT. Also use non-negated `ledon`. Add initialization into bringup code. Signed-off-by: Martin Vajnar <martin.vajnar@gmail.com>
acassis
approved these changes
Jun 28, 2026
simbit18
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To make
USERLEDdriver working on the stm32f746g-disco board, the following changes were made:BOARD_LED1and associated bit maskBOARD_LED1_BITledonImpact
USERLEDdriver can be used on the stm32f746g-disco board.Testing
Tested on stm32f746g-disco board.