stdbit.h: fix compilation error of generic stdc_ functions#19221
Merged
Conversation
Generic stdc_ functions use _Generic macro, but this requires the type specific functions stdc_*_uc, stdc_*_ul and so on to be functions, not just another macro definitions. This commit fixes the issue by ensuring all type specific functions are static inline functions, not macro definitions. There is no change other in the functionality or implementation. Signed-off-by: Michal Lenc <michallenc@seznam.cz>
Contributor
Author
|
ping @jerpelea for 13.0 backport |
jerpelea
approved these changes
Jun 26, 2026
This was referenced Jun 26, 2026
xiaoxiang781216
approved these changes
Jun 26, 2026
acassis
approved these changes
Jun 26, 2026
anchao
approved these changes
Jun 26, 2026
linguini1
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generic
stdc_functions use_Genericmacro, but this requires the type specific functionsstdc_*_uc,stdc_*_uland so on to be functions, not just another macro definitions.This commit fixes the issue by ensuring all type specific functions are static inline functions, not macro definitions.
Impact
Fixes the compilation error of
stdc_leading_ones,stdc_trailing_ones,stdc_count_zeros,stdc_count_ones,stdc_has_single_bitandstdc_bit_widthfunctions.Testing
Testing application is here. I will create a separate merge request for tests later.
Compile errors before the fix:
The application compiles and all tests pass after the fix.