1wire: Move onewire_valid_rom to 1wire_crc.h

[ghnotgood]

To let developers use all procedures implemented in the corresponding .c file when 1wire_crc.h is included.

Summary

When nuttx/1wire/1wire_crc.h is included, all the procedures implemented in the drivers/1wire/1wire_crc.c all available except onewire_valid_rom.

Impact

onewire_valid_rom will be available after #include <nuttx/1wire/1wire_crc.h>.

Testing

I have compiled the NuttX with the custom implementation of 1wire protocol that uses onewire_valid_rom and sucessfuly used it.

I have not tested this on a board where 1wire is used. Could anyone, please, do it? It looks onewire_valid_rom is used only in drivers/1wire/1wire.c and

@@ -35,6 +35,7 @@
 #include <nuttx/kmalloc.h>
 #include <nuttx/1wire/1wire_master.h>
 #include <nuttx/1wire/1wire.h>
+#include <nuttx/1wire/1wire_crc.h>
 
 #include "1wire_internal.h"

is a part of this PR, but better save than sorry. Thanks!

[github-actions]

MemBrowse Memory Report

No memory changes detected for:

• arduino-mega2560
• esp32-devkitc
• hifive1-revb
• mirtoo
• qemu-armv8a
• qemu-intel64
• rx65n-rsk2mb
• s698pm-dkit
• stm32-nucleo-f103rb

[simbit18]

@michael-membrowse Please fix job [analyze (stm32-nucleo-f103rb, nucleo-f103rb:nsh, nuttx, boards/arm/stm32/nucleo-f103rb/scripts/ld.script]

ERROR: Linker script not found: sources/nuttx/boards/arm/stm32/nucleo-f103rb/scripts/ld.script

https://github.com/apache/nuttx/actions/runs/28171450180/job/83436526606?pr=19216#logs

new path
nuttx/boards/arm/stm32f1/nucleo-f103rb/scripts/ld.script

[michael-membrowse]

@simbit18 please rebase, the fix was already pushed

[simbit18]

@ghnotgood please rebase

[linguini1]

What's the point of exposing the header?

[ghnotgood]

What's the point of exposing the header?

The header is exposed already. This change fixes the inconsistency where the onewire_valid_rom function implemented in 1wire_crc.c file is not declared in 1wire_crc.h like other functions.

And, if that was a question, it helps myself to use onewire_valid_rom to validate received ROM in custom board code.

[linguini1]

And, if that was a question, it helps myself to use onewire_valid_rom to validate received ROM in custom board code.

Does that mean you can test on a board?